mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
560cb50dae
Fixes https://github.com/flutter/flutter/issues/180101. Our hot reloading behavior for shader uniforms only handled the case where uniforms were reordered. In the case that a uniform was renamed or deleted, and a user had acquired a handle to that uniform via `getUniformFloat`, we would try (and fail) to locate that uniform in the shader, and the program would crash. This PR fixes that issue and adds a test to verify. Also manually verified on mac and android ## Pre-launch Checklist - [ x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ x] I signed the [CLA]. - [ x] I listed at least one issue that this PR fixes in the description above. - [ x] I updated/added relevant documentation (doc comments with `///`). - [ x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Dart UI Tests
The tests in this directory are written in Dart and run on the Flutter engine,
typically testing functionality that is not easily tested with C++ tests or
is best tested at a higher level (i.e. importing dart:ui).
Running the tests
The simplest way to run these tests is using run_tests.py:
./testing/run_tests.py --type=dart
Or, to run a specific test, provide the base file name as --dart-filter:
./testing/run_tests.py --type=dart --dart-filter=image_filter_test.dart
Note that the tests are compiled as Dart kernel files, and not run from source, if any changes are made to the tests, you will need to recompile them before running the tests:
# At the time of this writing, 'et build' did not work with Dart targets.
# Instead, use the following command to build the tests.
ninja -C ../out/host_debug_unopt_arm64 compile_image_filter_test.dart
To view the outputted golden files locally, you'll need to open the generated output folder, which will vary based on both your current target architecture and the test suite you're running.
For example, for the above test on host_debug_unopt_arm64:
open ../out/host_debug_unopt_arm64/gen/skia_gold_image_filter_test.dart_iplr