mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
<!-- start_original_pr_link --> Reverts: flutter/flutter#169273 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: jason-simmons <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: seeing flakes of `dart_data_asset_test.dart` CI runs for various PRs got errors in the `tool_integration_tests` shards. The errors occurred on multiple platforms (Linux, Mac, and Windows). Affected PRs include: https://github.com/flutter/flutter/pull/170022, https://github.com/flutter/flutter/pull/169995 LUCI log of an error: https://ci.chromium.org/ui/p/flutter/builders/try/Windows%20t <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: mosuem <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {bkonyi} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: Refiling of #164094, which itself is a rebase of #159675 This PR adds bundling support for the experimental dart data asset feature: Dart packages with hooks can now emit data assets which the flutter tool will bundle. It relies on flutter's existing asset bundling mechanism (e.g. entries in AssetManifest.json, DevFS syncing in reload/restart, ...). The support is added under an experimental flag (similar to the existing native assets experimental flag). Also, kNativeAssets is removed to also bundle data assets on flutter build bundle. The chrome sandbox is disabled as per #165664. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
85 lines
2.3 KiB
Dart
85 lines
2.3 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:meta/meta.dart';
|
|
|
|
import 'base/platform.dart';
|
|
import 'features.dart';
|
|
import 'flutter_features_config.dart';
|
|
import 'version.dart';
|
|
|
|
@visibleForTesting
|
|
mixin FlutterFeatureFlagsIsEnabled implements FeatureFlags {
|
|
@protected
|
|
Platform get platform;
|
|
|
|
@override
|
|
bool get isLinuxEnabled => isEnabled(flutterLinuxDesktopFeature);
|
|
|
|
@override
|
|
bool get isMacOSEnabled => isEnabled(flutterMacOSDesktopFeature);
|
|
|
|
@override
|
|
bool get isWebEnabled => isEnabled(flutterWebFeature);
|
|
|
|
@override
|
|
bool get isWindowsEnabled => isEnabled(flutterWindowsDesktopFeature);
|
|
|
|
@override
|
|
bool get isAndroidEnabled => isEnabled(flutterAndroidFeature);
|
|
|
|
@override
|
|
bool get isIOSEnabled => isEnabled(flutterIOSFeature);
|
|
|
|
@override
|
|
bool get isFuchsiaEnabled => isEnabled(flutterFuchsiaFeature);
|
|
|
|
@override
|
|
bool get areCustomDevicesEnabled => isEnabled(flutterCustomDevicesFeature);
|
|
|
|
@override
|
|
bool get isCliAnimationEnabled {
|
|
if (platform.environment['TERM'] == 'dumb') {
|
|
return false;
|
|
}
|
|
return isEnabled(cliAnimation);
|
|
}
|
|
|
|
@override
|
|
bool get isNativeAssetsEnabled => isEnabled(nativeAssets);
|
|
|
|
@override
|
|
bool get isSwiftPackageManagerEnabled => isEnabled(swiftPackageManager);
|
|
}
|
|
|
|
interface class FlutterFeatureFlags extends FeatureFlags with FlutterFeatureFlagsIsEnabled {
|
|
FlutterFeatureFlags({
|
|
required FlutterVersion flutterVersion,
|
|
required FlutterFeaturesConfig featuresConfig,
|
|
required this.platform,
|
|
}) : _flutterVersion = flutterVersion,
|
|
_featuresConfig = featuresConfig;
|
|
|
|
final FlutterVersion _flutterVersion;
|
|
final FlutterFeaturesConfig _featuresConfig;
|
|
|
|
@override
|
|
@protected
|
|
final Platform platform;
|
|
|
|
@override
|
|
bool isEnabled(Feature feature) {
|
|
final String currentChannel = _flutterVersion.channel;
|
|
final FeatureChannelSetting featureSetting = feature.getSettingForChannel(currentChannel);
|
|
|
|
// If unavailable, then no setting can enable this feature.
|
|
if (!featureSetting.available) {
|
|
return false;
|
|
}
|
|
|
|
// Otherwise, read it from environment variable > project manifest > global config
|
|
return _featuresConfig.isEnabled(feature) ?? featureSetting.enabledByDefault;
|
|
}
|
|
}
|