mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
8268427c5e
- Fix https://github.com/flutter/flutter/issues/177911
- In this PR:
- Avoid auto-overriding border side color with `dayForegroundColor` when
users specify an explicit border color
- Improve `todayBorder` documentation to clarify cases can happen.
- Add an opacity check: this is because if we don't respect/specify an
explicit border color, we still need to keep enabled/disabled states
(state-aware) that `dayForegroundColor` always does:
de3f804590/packages/flutter/lib/src/material/date_picker_theme.dart (L1174)
So we need a fallback compatibility here:
```dart
final bool hasCustomBorderColor =
datePickerTheme.todayBorder != null && datePickerTheme.todayBorder?.color.opacity != 0.0;
final BorderSide todayBorderSide = hasCustomBorderColor
? datePickerTheme.todayBorder!
: (datePickerTheme.todayBorder ?? defaults.todayBorder!).copyWith(
color: dayForegroundColor,
);
```
- Added 3 tests in `calendar_date_picker_test.dart`.
- Update test data in `date_picker_theme_test.dart`: Updated todayBorder
from `BorderSide(width: 3)` to `BorderSide(width: 3, color:
Color(0x00000000))` to maintain backward compatible behavior in tests:
after changing color to transparent, it should fall back to
`todayForegroundColor`. This is because the test's real purpose was to
verify theme properties work, and it was expecting foreground color
(which is the bug reported).
<details open>
<summary>Demo</summary>
| Before | After |
| --------------- | --------------- |
<img width="400"
src="https://github.com/user-attachments/assets/59c70071-d278-46f8-a566-40589cf01f9a">
| <img width="400"
src="https://github.com/user-attachments/assets/a4309fb0-7360-4c11-a9c1-dd1f1ebf9190">
</details>
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Signed-off-by: huycozy <huy@nevercode.io>
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>