mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
ef99e4345d
Recycles command buffers instead of deleting them when they are done being used. @jonahwilliams profiled the Gallery on the Pixel 7 pro and saw that sometimes `RenderPassVK::OnEncodeCommands` takes a long time in https://github.com/flutter/flutter/issues/132690. After adding adding more tracing it was found that the culprit was deleting the CommandBuffers on the raster thread. This PR removes the deletion of the CommandBuffers and instead resets and recycles them.  > where GARBO2 is > ```c++ > void CommandPoolVK::GarbageCollectBuffersIfAble() { > TRACE_EVENT0("impeller", "CommandPoolVK::GARBO2"); > if (std::this_thread::get_id() != owner_id_) { > return; > } > buffers_to_collect_.clear(); > } > ``` This approach matches the guidances from ["Vulkan Best Practice for Mobile Developers"](https://arm-software.github.io/vulkan_best_practice_for_mobile_developers/samples/performance/command_buffer_usage/command_buffer_usage_tutorial.html) where it is preferable to recycle command buffers than delete them. Also, the recommendation is that if you are not reusing command buffers that you should periodically reset the pool, which we weren't doing. issue: https://github.com/flutter/flutter/issues/132690 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat