mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00

History

auto-submit[bot] ebc414337d

Reverts "Prevent LayoutBuilder from rebuilding more than once (#147856 )" (#149279 )

Reverts: flutter/flutter#147856
Initiated by: loic-sharma
Reason for reverting: tree is closed with errors like: 

```
test/integration.shard/break_on_framework_exceptions_test.dart: breaks when rebuilding dirty elements throws [E]
  Expected: <45>
    Actual: <2756>
  
  package:matcher                                                       expect
  test\integration.shard\break_on_framework_exceptions_test.dart 56:5   main.expectException
  ===== asynchronous gap ===
Original PR Author: LongCatIsLooong

Reviewed By: {goderbauer}

This change reverts the following previous change:
Fixes https://github.com/flutter/flutter/issues/146379: introduces `Element.buildScope` which `BuildOwner.buildScope` uses to identify subtrees that need skipping (those with different `BuildScope`s). If `Element.update` calls `updateChild` then dirty children will still be rebuilt regardless of their build scopes. 

This also introduces `LayoutBuilder.applyDoubleRebuildFix` migration flag which should only live for a week or less. 

Caveats: 

`LayoutBuilder`'s render object calls `markNeedsLayout` if a descendant Element is dirty. Since `markNeedsLayout` also implies `markNeedsPaint`, the render object is going to be very repaint/relayout-happy.

Tests: 

Presubmits with the migration flag set to true: https://github.com/flutter/flutter/pull/147856/checks?check_run_id=24629865893

2024-05-29 23:29:19 +00:00

lib

Reverts "Prevent LayoutBuilder from rebuilding more than once (#147856 )" (#149279 )

2024-05-29 23:29:19 +00:00

test

Reverts "Prevent LayoutBuilder from rebuilding more than once (#147856 )" (#149279 )

2024-05-29 23:29:19 +00:00

test_fixes

Deprecate ButtonBar, ButtonBarThemeData, and ThemeData.buttonBarTheme (#145523 )

2024-04-01 11:39:48 +00:00

test_private

Unpin DDS and roll pub packages (#147925 )

2024-05-08 10:35:28 +01:00

test_profile

…

test_release

…

analysis_options.yaml

…

build.yaml

…

dart_test.yaml

…

LICENSE

…

pubspec.yaml

Unpin DDS and roll pub packages (#147925 )

2024-05-08 10:35:28 +01:00

README.md

…

README.md

Flutter

Flutter is a new way to build high-performance, cross-platform mobile, web, and desktop apps. Flutter is optimized for today's — and tomorrow's — mobile and desktop devices. We are focused on low-latency input and high frame rates on all platforms.

See the getting started guide for information about using Flutter.