mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
ba117366ef
This PR replaces the unused `PrerollContext::child_paint_bounds` with `PrerollContext::cull_rect` so we can prune unnecessary preroll tasks (especially cache) based on clips. This PR fixes https://github.com/flutter/flutter/issues/24712 Performance test has been added (https://github.com/flutter/flutter/pull/25381) to make sure that we won't regress again in the future. Note that the cull_rect here is very similar to those removed in https://github.com/flutter/engine/pull/6352 . We can't compute cull rects in SceneBuilder because of retained layers. But we can still compute and use them to optimize performance in Preroll.
71 lines
2.2 KiB
C++
71 lines
2.2 KiB
C++
// Copyright 2013 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "flutter/flow/layers/clip_path_layer.h"
|
|
|
|
#if defined(OS_FUCHSIA)
|
|
|
|
#include "lib/ui/scenic/fidl_helpers.h" // nogncheck
|
|
|
|
#endif // defined(OS_FUCHSIA)
|
|
|
|
namespace flow {
|
|
|
|
ClipPathLayer::ClipPathLayer(Clip clip_behavior)
|
|
: clip_behavior_(clip_behavior) {}
|
|
|
|
ClipPathLayer::~ClipPathLayer() = default;
|
|
|
|
void ClipPathLayer::Preroll(PrerollContext* context, const SkMatrix& matrix) {
|
|
SkRect previous_cull_rect = context->cull_rect;
|
|
SkRect clip_path_bounds = clip_path_.getBounds();
|
|
if (context->cull_rect.intersect(clip_path_bounds)) {
|
|
SkRect child_paint_bounds = SkRect::MakeEmpty();
|
|
PrerollChildren(context, matrix, &child_paint_bounds);
|
|
|
|
if (child_paint_bounds.intersect(clip_path_bounds)) {
|
|
set_paint_bounds(child_paint_bounds);
|
|
}
|
|
}
|
|
context->cull_rect = previous_cull_rect;
|
|
}
|
|
|
|
#if defined(OS_FUCHSIA)
|
|
|
|
void ClipPathLayer::UpdateScene(SceneUpdateContext& context) {
|
|
FML_DCHECK(needs_system_composite());
|
|
|
|
// TODO(MZ-140): Must be able to specify paths as shapes to nodes.
|
|
// Treating the shape as a rectangle for now.
|
|
auto bounds = clip_path_.getBounds();
|
|
scenic::Rectangle shape(context.session(), // session
|
|
bounds.width(), // width
|
|
bounds.height() // height
|
|
);
|
|
|
|
// TODO(liyuqian): respect clip_behavior_
|
|
SceneUpdateContext::Clip clip(context, shape, bounds);
|
|
UpdateSceneChildren(context);
|
|
}
|
|
|
|
#endif // defined(OS_FUCHSIA)
|
|
|
|
void ClipPathLayer::Paint(PaintContext& context) const {
|
|
TRACE_EVENT0("flutter", "ClipPathLayer::Paint");
|
|
FML_DCHECK(needs_painting());
|
|
|
|
SkAutoCanvasRestore save(context.internal_nodes_canvas, true);
|
|
context.internal_nodes_canvas->clipPath(clip_path_,
|
|
clip_behavior_ != Clip::hardEdge);
|
|
if (clip_behavior_ == Clip::antiAliasWithSaveLayer) {
|
|
context.internal_nodes_canvas->saveLayer(paint_bounds(), nullptr);
|
|
}
|
|
PaintChildren(context);
|
|
if (clip_behavior_ == Clip::antiAliasWithSaveLayer) {
|
|
context.internal_nodes_canvas->restore();
|
|
}
|
|
}
|
|
|
|
} // namespace flow
|