mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
26030557b1
This was broken in https://github.com/flutter/flutter/pull/122452. The culprit is that `PipelineOwner.ensureSemantics` doesn't turn on semantics for the entire app, it pretends to only turn it on for the local `PipelineOwner`. Unfortunately, that local `PipelineOwner` is never informed that it should produce semantics when semantics are not turned on globally. So, `PipelineOwner.ensureSemantics` is essentially without effect if semantics are not already turned on globally. I can't think of a use case where it would be useful to only turn on semantics for a particular pipeline owner and fixing `PipelineOwner.ensureSemantics` would get pretty messy with performance implications even if semantics are turned off. So, this PR deprecates that functionality and moves the `SemanticsDebugger` to the global semantics API. Fixes https://github.com/flutter/flutter/issues/147665.
74 lines
2.5 KiB
Dart
74 lines
2.5 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:flutter/rendering.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
import 'rendering_tester.dart';
|
|
|
|
void main() {
|
|
TestRenderingFlutterBinding.ensureInitialized();
|
|
|
|
test('only send semantics update if semantics have changed', () {
|
|
final TestRender testRender = TestRender()
|
|
..properties = const SemanticsProperties(label: 'hello')
|
|
..textDirection = TextDirection.ltr;
|
|
|
|
final RenderConstrainedBox tree = RenderConstrainedBox(
|
|
additionalConstraints: const BoxConstraints.tightFor(height: 20.0, width: 20.0),
|
|
child: testRender,
|
|
);
|
|
int semanticsUpdateCount = 0;
|
|
final SemanticsHandle semanticsHandle = TestRenderingFlutterBinding.instance.ensureSemantics();
|
|
TestRenderingFlutterBinding.instance.pipelineOwner.semanticsOwner!.addListener(
|
|
() {
|
|
++semanticsUpdateCount;
|
|
},
|
|
);
|
|
|
|
layout(tree, phase: EnginePhase.flushSemantics);
|
|
|
|
// Initial render does semantics.
|
|
expect(semanticsUpdateCount, 1);
|
|
expect(testRender.describeSemanticsConfigurationCallCount, isPositive);
|
|
|
|
testRender.describeSemanticsConfigurationCallCount = 0;
|
|
semanticsUpdateCount = 0;
|
|
|
|
// Request semantics update even though nothing changed.
|
|
testRender.markNeedsSemanticsUpdate();
|
|
pumpFrame(phase: EnginePhase.flushSemantics);
|
|
|
|
// Object is asked for semantics, but no update is sent.
|
|
expect(semanticsUpdateCount, 0);
|
|
expect(testRender.describeSemanticsConfigurationCallCount, isPositive);
|
|
|
|
testRender.describeSemanticsConfigurationCallCount = 0;
|
|
semanticsUpdateCount = 0;
|
|
|
|
// Change semantics and request update.
|
|
testRender.properties = const SemanticsProperties(label: 'bye');
|
|
testRender.markNeedsSemanticsUpdate();
|
|
pumpFrame(phase: EnginePhase.flushSemantics);
|
|
|
|
// Object is asked for semantics, and update is sent.
|
|
expect(semanticsUpdateCount, 1);
|
|
expect(testRender.describeSemanticsConfigurationCallCount, isPositive);
|
|
|
|
semanticsHandle.dispose();
|
|
});
|
|
}
|
|
|
|
class TestRender extends RenderSemanticsAnnotations {
|
|
TestRender() : super(properties: const SemanticsProperties());
|
|
|
|
int describeSemanticsConfigurationCallCount = 0;
|
|
|
|
@override
|
|
void describeSemanticsConfiguration(SemanticsConfiguration config) {
|
|
super.describeSemanticsConfiguration(config);
|
|
describeSemanticsConfigurationCallCount += 1;
|
|
}
|
|
}
|