Loïc Sharma e1b38345d3 [Windows] Add/remove view failures should not hang (flutter/engine#52164) ...

If the embedder API's `FlutterEngineAddView` and `FlutterEngineRemoveView` don't return `kSuccess`, their callbacks won't be invoked. See: [flutter.dev/go/multi-view-embedder-apis](https://flutter.dev/go/multi-view-embedder-apis).

Previously, the Windows embedder would hang in this scenario as it blocks until the callbacks are invoked. Now, the Windows embedder only blocks if these embedder APIs return `kSuccess`.

Kudos to @dkwingsmt for catching this!

Part of https://github.com/flutter/flutter/issues/144810
Part of https://github.com/flutter/flutter/issues/142845

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

2024-04-17 16:44:28 +00:00

engine/src/flutter

[Windows] Add/remove view failures should not hang (flutter/engine#52164)

2024-04-17 16:44:28 +00:00

DEPS

Roll Skia from 1832de338187 to 4b3b84c0beeb (1 revision) (flutter/engine#52192)

2024-04-17 08:11:49 +00:00

Description

Flutter makes it easy and fast to build beautiful apps for mobile and beyond

androidapp-frameworkcross-platformdartdart-platformdesktopflutterflutter-packagefuchsiaioslinux-desktopmacosmaterial-designmobilemobile-developmentskiawebweb-frameworkwindows

2.5 GiB

Languages

Dart 75%

C++ 16.5%

Objective-C++ 2.9%

Java 2.8%

Objective-C 0.7%

Other 1.9%