mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
e1a5c99a2a
Closes https://github.com/flutter/flutter/issues/145957. As @jonahwilliams and @johnmccutchan and I discussed (https://github.com/flutter/flutter/issues/144407), the functionality that was being tested was actually _Android's_ ability to rotate and crop `SurfaceTexture`-backed textures. This same functionality doesn't even exist in the `ImageReader`-based textures (read: modern Android devices): > Due to an oversight by Android, ImageReader backed surfaces do not respect metadata applied to the surface (rotation & crop). Rotation information is not available at all and crop information is corrupted by the ImageReader (only the width/height is propagated the origin offset is not). We might decide to re-add this functionality in the Dart `Texture` widget, but given we'll be migrating our plugins to `SurfaceProducer` (again, read: using `ImageTexture` for most Android phones), it's pointless to test this (and isn't even testing Flutter's code). This reduces our test suite significantly (8 tests down to 2), which should also help with runtime and flakiness. /cc @zanderso who I'm sure will be stoked.