mirror of
https://github.com/flutter/flutter.git
synced 2026-02-06 03:39:05 +08:00
8124e89c63
From looking closer at the logs, I think the failure is that the adb command isn't specifying the device. This passes locally because I only have one device, but then fails on CI. I missed this when looking at the [logs](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8699178787799824705/+/u/run_android_verified_input_test/stdout) originally: ``` [2025-11-03 15:50:32.967241] [STDOUT] stdout: [ ] test_driver/main_test.dart 34:40 main.<fn>.<fn> [2025-11-03 15:50:35.960806] [STDOUT] stdout: [+2993 ms] Expected: <0> [2025-11-03 15:50:35.960858] [STDOUT] stdout: [ ] Actual: <1> [2025-11-03 15:50:35.960898] [STDOUT] stdout: [ ] package:matcher/src/expect/expect.dart 149:31 fail [2025-11-03 15:50:35.960906] [STDOUT] stdout: [ ] package:matcher/src/expect/expect.dart 144:3 _expect [2025-11-03 15:50:35.960946] [STDOUT] stdout: [ ] package:matcher/src/expect/expect.dart 56:3 expect [2025-11-03 15:50:35.960957] [STDOUT] stdout: [ ] test_driver/main_test.dart 44:7 main.<fn> ``` The failed expect there isn't related to the verification, it is an expect on the exit code of the adb command: https://github.com/flutter/flutter/blob/master/dev/integration_tests/android_verified_input/test_driver/main_test.dart#L44 So the adb command is failing on CI. I think it is for the reason above. This change makes the device id available to the driver tests that are run by the devicelab harness, and then pipes it through to ADB. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md Co-authored-by: Gray Mackall <mackall@google.com>
This directory contains tools and resources that the Flutter team uses during the development of the framework. The tools in this directory should not be necessary for developing Flutter applications, though of course, they may be interesting if you are curious.
The tests in this directory are run in the framework_tests_misc-*
shards.