Chris Bracken d260fc82cd [embedder] Ensure FlutterMetalTexture cleanup call (flutter/engine#38038) ...

This ensures FlutterMetalTexture.destruction_callback gets called.

FlutterRendererConfig.get_next_drawable_callback holds a callback used by the embedder API to request a drawable; in the case of Metal, this drawable is a FlutterMetalTexture.

FlutterMetalTexture.destruction_callback should be called when it's safe to release resources associated with the FlutterMetalTexture. This callback is not currently invoked for textures returned via FlutterRendererConfig.get_next_drawable_callback; instead we unpack the returned struct and pass it on.

In the compositor codepath, we do create an SkSurface that triggers the destruction callback, here:
bbdb5d6a3e/shell/platform/embedder/embedder.cc (L868-L881)

Issue: https://github.com/flutter/flutter/issues/116381

2022-12-03 01:30:23 -08:00

engine/src/flutter

[embedder] Ensure FlutterMetalTexture cleanup call (flutter/engine#38038)

2022-12-03 01:30:23 -08:00

DEPS

Roll Skia from 6fdf7181e374 to d0e3902c97b3 (6 revisions) (flutter/engine#38051)

2022-12-03 05:46:27 +00:00

Description

Flutter makes it easy and fast to build beautiful apps for mobile and beyond

androidapp-frameworkcross-platformdartdart-platformdesktopflutterflutter-packagefuchsiaioslinux-desktopmacosmaterial-designmobilemobile-developmentskiawebweb-frameworkwindows

2.5 GiB

Languages

Dart 75%

C++ 16.5%

Objective-C++ 2.9%

Java 2.8%

Objective-C 0.7%

Other 1.9%