flutter_flutter

mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00

History

Bruno Leroux ce5194184d [Android] Fix enableSuggestions set to false not honored (flutter/engine#46037 )

## Description

This PR fixes an issue where setting `TextField.enableSuggestions` to false was not honored on Android.

Several Android devices (Samsung) and/or IMEs (including GBoard) does not disabled suggestions when `InputType.TYPE_TEXT_FLAG_NO_SUGGESTIONS `flag is set. The common solution is to rely on the following flag:  ~~`InputType.TYPE_TEXT_VARIATION_PASSWORD`~~ `InputType.TYPE_TEXT_VARIATION_VISIBLE_PASSWORD`.

Reference:
- https://issuetracker.google.com/issues/36934423#comment4
- https://stackoverflow.com/questions/33148168/inputtype-type-text-flag-no-suggestions-in-samsung/33227237#33227237
- Existing comment on the codebase:
195a313245/shell/platform/android/io/flutter/plugin/editing/TextInputPlugin.java (L270)

## Related Issue

Fixes https://github.com/flutter/flutter/issues/71679.

## Tests

Adds 1 test.

2023-09-26 20:39:05 +00:00

common

[Impeller] Reland: construct text frames on UI thread. (flutter/engine#46115 )

2023-09-22 17:46:32 +00:00

gpu

Migrate GrMipmapped->skgpu::Mipmapped (flutter/engine#45881 )

2023-09-15 11:48:20 -04:00

platform

[Android] Fix enableSuggestions set to false not honored (flutter/engine#46037 )

2023-09-26 20:39:05 +00:00

profiling

Remove deprecated MOCK_METHODx calls (flutter/engine#45307 )