Chinmay Garde c721e67cb7 Isolates launched by the engine instance use the settings of that instance. (flutter/engine#22052) ...

This regression was introduced in https://github.com/flutter/engine/pull/21820
for sound-null safety. The settings used to launch the VM were incorrectly used
to determine the isolate lifecycle callbacks. Since the first shell/engine in
the process also starts the VM, these objects are usually identical. However,
for subsequent engine shell/engine launches, the callbacks attached to the new
settings object would be ignored. The unit-test harness is also structured in
such a way that each test case tears down the VM before the next. So all
existing tests created a bespoke VM for the test run, and, the tests that did
create multiple isolates did not also test attaching callbacks to the settings
object.

Fixes https://github.com/flutter/engine/pull/22041

2020-10-22 02:20:50 -07:00

..

src/flutter

Isolates launched by the engine instance use the settings of that instance. (flutter/engine#22052)

2020-10-22 02:20:50 -07:00