mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00

History

[material/menu_anchor.dart] Remove _MenuAnchorState from parent when disposed. (#149586 )

`_MenuAnchorState` now removes itself from its parent regardless of whether `_MenuAnchorState._isOpen` is true.

Before, _MenuAnchorState would only detach itself when `_MenuAnchorState._isOpen == true`. This led to _MenuAnchorState being retained until an anchor's parent was disposed.

Before:

https://github.com/flutter/flutter/assets/59215665/48f1617a-a3d0-49ab-a767-f41e3a30ea41

After:

https://github.com/flutter/flutter/assets/59215665/31312bb6-49ec-4083-b8de-e9ae2a42a8b3

Fixes https://github.com/flutter/flutter/issues/149584

I was a bit unsure what the best way of testing this change would be, and wanted feedback from the Flutter team. Is there a way for us to view at the instance count of `_MenuAnchorState`, or expose `_MenuAnchorState._anchorChildren.length` for testing?

- [] I added new tests to check the change I am making, or this PR is [test-exempt].

2024-06-20 18:10:05 +00:00

lib

[material/menu_anchor.dart] Remove _MenuAnchorState from parent when disposed. (#149586 )

2024-06-20 18:10:05 +00:00

test

[material/menu_anchor.dart] Remove _MenuAnchorState from parent when disposed. (#149586 )

2024-06-20 18:10:05 +00:00

test_fixes

Update old wiki links (#149544 )

2024-06-17 17:26:08 +00:00

test_private

Update old wiki links (#149544 )

2024-06-17 17:26:08 +00:00

test_profile

…

test_release

…

analysis_options.yaml

…

build.yaml

…

dart_test.yaml

…

LICENSE

…

pubspec.yaml

Update old wiki links (#149544 )

2024-06-17 17:26:08 +00:00

README.md

…

README.md

Flutter

Flutter is a new way to build high-performance, cross-platform mobile, web, and desktop apps. Flutter is optimized for today's — and tomorrow's — mobile and desktop devices. We are focused on low-latency input and high frame rates on all platforms.

See the getting started guide for information about using Flutter.