DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-01-18 19:54:36 +08:00
Code Issues Packages Projects Releases Wiki Activity
flutter_flutter/dev
History
Bruno Leroux c059c9b7da
Fix TextButton.icon breaks focus traversal and ink effect when toggling icon (#176579) 
## Description

This PR changes `TextButton.icon` to avoid building a different widget.
When a different widget is created the whole subtree is recreated which
leads to various issues (Focus and A11y issues for instance).
The change is similar to https://github.com/flutter/flutter/pull/175810
which fixed the exact same problem for `OutlinedButton.icon`.

## Related Issue

Fixes [TextButton.icon breaks focus traversal and ink effect when
toggling icon](https://github.com/flutter/flutter/issues/173944)

## Tests

- Adds 1 test

---------

Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>
2025-10-28 22:07:10 +00:00
..
a11y_assessments
Regenerated lockfiles for New Template Values (#177617)
2025-10-27 22:55:52 +00:00
automated_tests
Bump Dart to 3.8 and reformat (#171703)
2025-07-07 17:58:32 +00:00
benchmarks
Regenerated lockfiles for New Template Values (#177617)
2025-10-27 22:55:52 +00:00
bots
Roll dartdoc to 9.0.0 (#177590)
2025-10-27 17:28:12 +00:00
customer_testing
Roll customer tests (#177409)
2025-10-23 22:21:11 +00:00
devicelab
Bump Templates To Correct Versions (#177416)
2025-10-24 20:16:13 +00:00
docs
Bump Dart to 3.8 and reformat (#171703)
2025-07-07 17:58:32 +00:00
forbidden_from_release_tests
Bump Dart to 3.8 and reformat (#171703)
2025-07-07 17:58:32 +00:00
integration_tests
Fix TextButton.icon breaks focus traversal and ink effect when toggling icon (#176579)
2025-10-28 22:07:10 +00:00
manual_tests
Regenerated lockfiles for New Template Values (#177617)
2025-10-27 22:55:52 +00:00
missing_dependency_tests
Bump Dart to 3.8 and reformat (#171703)
2025-07-07 17:58:32 +00:00
packages_autoroller
Migrate to null aware elements - Part 5 (#172418)
2025-07-30 18:40:09 +00:00
snippets
Bump Dart to 3.8 and reformat (#171703)
2025-07-07 17:58:32 +00:00
tools
Bump Templates To Correct Versions (#177416)
2025-10-24 20:16:13 +00:00
tracing_tests
[Gradle 9] Resolve Gradle 9 Deprecations in flutter/flutter part 1 (#176865)
2025-10-16 20:16:20 +00:00
analysis_options.yaml
…
checks
Start a dev/checks_tool directory. (#170493)
2025-06-14 15:51:26 +00:00
README.md
…

README.md

This directory contains tools and resources that the Flutter team uses during the development of the framework. The tools in this directory should not be necessary for developing Flutter applications, though of course, they may be interesting if you are curious.

The tests in this directory are run in the framework_tests_misc-* shards.