mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
7647360840
I changed skydb start to take a build directory and read the configuration out of gn args instead of --release, --debug, etc. This should be more flexable and handle all the crazy asan cases mopy/config.py tries to. Once we merge sky/tools into mojo/tools we should make mopy/config use this method too. This follows similar patterns to what mojo/tools/android_mojo_shell.py does, but doesn't use as much of the (old) android_commands and forwarder logic. We could even remove all of that build/android/pylib code by calling the (new) adb reverse instead of using Forwarder (in a later patch). This still only supports a single skydb running at once, but it should be trivial to move the skydb.pids file into the build directory or to have it support more than one instance. The big question there is what the command-line usage should look like when supporting more than one running instance. See the mojo-dev thread on the subject. R=abarth@chromium.org Review URL: https://codereview.chromium.org/816693006