mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
c6baaaf75a
The behavior of acquire+release annotation handling has changed in https://reviews.llvm.org/D49355 which breaks the build with the new Clang. However, as has been pointed out, the acquire+release isn't the right way to prevent double locking as the annotations negate each other; the correct way is to use excludes or negative requires. Using excludes annotations also requires using std::lock_guard instead of std::unique_lock because the latter doesn't have the thread annotations due to deferred locking which is not needed in Flutter and so std::lock_guard is a sufficient alternative.
55 lines
1.5 KiB
C++
55 lines
1.5 KiB
C++
// Copyright 2018 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef FLUTTER_LIB_UI_CALLBACK_CACHE_H_
|
|
#define FLUTTER_LIB_UI_CALLBACK_CACHE_H_
|
|
|
|
#include <map>
|
|
#include <memory>
|
|
#include <mutex>
|
|
#include <string>
|
|
|
|
#include "flutter/fml/macros.h"
|
|
#include "flutter/fml/synchronization/thread_annotations.h"
|
|
#include "third_party/dart/runtime/include/dart_api.h"
|
|
|
|
#define DART_CALLBACK_INVALID_HANDLE -1
|
|
|
|
namespace blink {
|
|
|
|
typedef struct {
|
|
std::string name;
|
|
std::string class_name;
|
|
std::string library_path;
|
|
} DartCallbackRepresentation;
|
|
|
|
class DartCallbackCache {
|
|
public:
|
|
static int64_t GetCallbackHandle(const std::string& name,
|
|
const std::string& class_name,
|
|
const std::string& library_path)
|
|
FML_LOCKS_EXCLUDED(mutex_);
|
|
|
|
static Dart_Handle GetCallback(int64_t handle) FML_LOCKS_EXCLUDED(mutex_);
|
|
|
|
static std::unique_ptr<DartCallbackRepresentation> GetCallbackInformation(
|
|
int64_t handle) FML_LOCKS_EXCLUDED(mutex_);
|
|
|
|
private:
|
|
static Dart_Handle LookupDartClosure(const std::string& name,
|
|
const std::string& class_name,
|
|
const std::string& library_path);
|
|
|
|
static std::mutex mutex_;
|
|
|
|
static std::map<int64_t, DartCallbackRepresentation> cache_
|
|
FML_GUARDED_BY(mutex_);
|
|
|
|
FML_DISALLOW_IMPLICIT_CONSTRUCTORS(DartCallbackCache);
|
|
};
|
|
|
|
} // namespace blink
|
|
|
|
#endif // FLUTTER_LIB_UI_CALLBACK_CACHE_H_
|