mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
3e26389e5d
Delete selection paint invalidation code. There is a slight change in behavior in FrameSelection::revealSelection. If you have a non-collapsed selection, then we'll center the start of the selection instead of the whole selection in some cases. There's a ton of callers of this code, so it's hard to be sure if any of this actually changes behavior for sky. In manual testing, I couldn't find any scenarios where there was a difference. Almost universally, when we call revealSelection, we have a CaretSelection. The only case I could think of where we have a RangeSelection is when modifying an off-screen selection (e.g. shift+right), but in that case we pass the RevealExtent option, so this patch doesn't change behavior there. Removing that caller makes all the rest of this rect computing code into dead code. R=abarth@chromium.org Review URL: https://codereview.chromium.org/823123003
74 lines
2.6 KiB
C++
74 lines
2.6 KiB
C++
/*
|
|
* Copyright (C) 2007 Apple Inc. All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
|
|
* EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
|
|
* PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
|
|
* CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
|
|
* EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
|
|
* PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
|
|
* PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
|
|
* OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#ifndef SKY_ENGINE_CORE_RENDERING_LAYOUTSTATE_H_
|
|
#define SKY_ENGINE_CORE_RENDERING_LAYOUTSTATE_H_
|
|
|
|
#include "sky/engine/platform/geometry/LayoutRect.h"
|
|
#include "sky/engine/wtf/HashMap.h"
|
|
#include "sky/engine/wtf/Noncopyable.h"
|
|
|
|
namespace blink {
|
|
|
|
class RenderBox;
|
|
class RenderObject;
|
|
class RenderInline;
|
|
class RenderView;
|
|
|
|
class LayoutState {
|
|
WTF_MAKE_NONCOPYABLE(LayoutState);
|
|
public:
|
|
// Constructor for root LayoutState created by RenderView
|
|
explicit LayoutState(RenderView&);
|
|
// Constructor for sub-tree Layout and RenderTableSections
|
|
explicit LayoutState(RenderObject& root);
|
|
|
|
LayoutState(RenderBox&, const LayoutSize& offset, bool containingBlockLogicalWidthChanged = false);
|
|
LayoutState(RenderInline&);
|
|
|
|
~LayoutState();
|
|
|
|
const LayoutSize& layoutOffset() const { return m_layoutOffset; }
|
|
bool containingBlockLogicalWidthChanged() const { return m_containingBlockLogicalWidthChanged; }
|
|
|
|
LayoutState* next() const { return m_next; }
|
|
|
|
RenderObject& renderer() const { return m_renderer; }
|
|
|
|
private:
|
|
bool m_containingBlockLogicalWidthChanged : 1;
|
|
|
|
LayoutState* m_next;
|
|
|
|
// x/y offset from container. Does not include relative positioning or scroll offsets.
|
|
LayoutSize m_layoutOffset;
|
|
|
|
RenderObject& m_renderer;
|
|
};
|
|
|
|
} // namespace blink
|
|
|
|
#endif // SKY_ENGINE_CORE_RENDERING_LAYOUTSTATE_H_
|