flutter_flutter/engine/core/css/resolver/SharedStyleFinder.h
Elliott Sprehn f4546b7716 Store features in the ScopedStyleResoolver.
This now means that using a class/id/attribute selector in one scope will
not cause style recalcs in other scopes in the page when something with
that feature changes.

It also removes an iteration over all the scopes that used to collect
features.

I also removed all the extra cases around adding/removing classes since
the general case can handle them.

In addition I removed the check for classStringHasClassName which looked
to see if the string was all whitespace. This check dated way back to
fixing an assert in code we don't even have anymore. Assertion fix aside
all the extra check optimized for was if you wrote class="  " with no
names, which will now cause an extra malloc of the SpaceSplitString::Data.
This seems super rare, it makes more sense to not scan the class string
every time the list of classes changes which is far more common than
setting a string of only whitespace.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/837883002
2015-01-06 22:22:44 -08:00

75 lines
2.6 KiB
C++

/*
* Copyright (C) 2013 Google, Inc.
* Copyright (C) 1999 Lars Knoll (knoll@kde.org)
* Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Library General Public
* License as published by the Free Software Foundation; either
* version 2 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Library General Public License for more details.
*
* You should have received a copy of the GNU Library General Public License
* along with this library; see the file COPYING.LIB. If not, write to
* the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
* Boston, MA 02110-1301, USA.
*/
#ifndef SKY_ENGINE_CORE_CSS_RESOLVER_SHAREDSTYLEFINDER_H_
#define SKY_ENGINE_CORE_CSS_RESOLVER_SHAREDSTYLEFINDER_H_
#include "sky/engine/core/css/resolver/ElementResolveContext.h"
#include "sky/engine/core/dom/Element.h"
namespace blink {
class ContainerNode;
class Element;
class RenderStyle;
class StyleResolver;
class SharedStyleFinder {
STACK_ALLOCATED();
public:
// RuleSets are passed non-const as the act of matching against them can cause them
// to be compacted. :(
SharedStyleFinder(const ElementResolveContext& context, StyleResolver& styleResolver)
: m_elementAffectedByClassRules(false)
, m_styleResolver(styleResolver)
, m_context(context)
, m_renderingParent(nullptr)
{ }
RenderStyle* findSharedStyle();
private:
Element* findElementForStyleSharing() const;
// Only used when we're collecting stats on styles.
bool documentContainsValidCandidate() const;
bool classNamesAffectedByRules(const Element&) const;
bool attributesAffectedByRules(const Element&) const;
bool canShareStyleWithElement(Element& candidate) const;
bool sharingCandidateHasIdenticalStyleAffectingAttributes(Element& candidate) const;
bool sharingCandidateCanShareHostStyles(Element& candidate) const;
bool sharingCandidateDistributedToSameInsertionPoint(Element& candidate) const;
Element& element() const { return *m_context.element(); }
Document& document() const { return element().document(); }
bool m_elementAffectedByClassRules;
StyleResolver& m_styleResolver;
const ElementResolveContext& m_context;
ContainerNode* m_renderingParent;
};
} // namespace blink
#endif // SKY_ENGINE_CORE_CSS_RESOLVER_SHAREDSTYLEFINDER_H_