mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
0b2269447f
Fixes https://github.com/flutter/flutter/issues/141823 Before this change, when a test would fail, the terminal would hang (by default for 30s) until killed by the test runner. Basically, [`runZonedGuarded`](https://api.flutter.dev/flutter/dart-async/runZonedGuarded.html) _does_ document (though not clearly) that a returned future should not be awaited: ```txt The zone will always be an error-zone ([Zone.errorZone](https://api.flutter.dev/flutter/dart-async/Zone/errorZone.html)), so returning a future created inside the zone, and waiting for it outside of the zone, will risk the future not being seen to complete. ``` For example, you can see other places in Dart and Flutter that we circumvent that problem: -5987563e4a/packages/flutter_tools/test/general.shard/base/async_guard_test.dart (L279-L306)-b04c9c127f/lib/src/dartdoc.dart (L258-L264)-d1afda52d2/lib/web_ui/dev/browser_process.dart (L20-L22)I'm open to suggestions on how to test this :) /cc @natebosch @jakemac53 @lrhn if you have any color commentary for us.