mirror of https://github.com/flutter/flutter.git synced 2026-02-12 22:03:04 +08:00

History

Fix cursor is not centered when cursorHeight is set (non-Apple platforms). (#145829 )

## Description

This PRs fixes the cursor vertical position when a custom cursor height is set on non-Apple platforms (on Apple platforms the cursor is already centered) .

| Before | After |
|--------|--------|
| ![image](https://github.com/flutter/flutter/assets/840911/2d1b855d-d36c-4941-85be-5044ea0e9bb2) | ![image](https://github.com/flutter/flutter/assets/840911/306510c8-42ca-45c7-8c25-ddfa2e22c7f3) | 

<details><summary>Code sample used for the screenshots (cursorHeight 18, font size 16, line height 2)</summary>

```dart
import 'package:flutter/material.dart';

void main() async {
  runApp(
    const MaterialApp(
      title: 'Flutter Demo',
      home: MyApp(),
    ),
  );
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const Scaffold(
      body: Center(
        child: TextField(
          cursorHeight: 18,
          style: TextStyle(fontSize: 16, height: 2),
        ),
      ),
    );
  }
}
``` 

</details> 

## Related Issue

Fixes https://github.com/flutter/flutter/issues/143480

## Tests

Adds 2 tests, updates 1.

2024-04-05 04:01:35 +00:00

lib

Fix cursor is not centered when cursorHeight is set (non-Apple platforms). (#145829 )

2024-04-05 04:01:35 +00:00

test

Fix cursor is not centered when cursorHeight is set (non-Apple platforms). (#145829 )

2024-04-05 04:01:35 +00:00

test_fixes

Deprecate ButtonBar, ButtonBarThemeData, and ThemeData.buttonBarTheme (#145523 )

2024-04-01 11:39:48 +00:00

test_private

Update material_color_utilities package version to latest 0.11.1 (#145959 )

2024-04-03 02:16:13 +00:00

test_profile

…

test_release

…

analysis_options.yaml

…

build.yaml

…

dart_test.yaml

…

LICENSE

…

pubspec.yaml

Update material_color_utilities package version to latest 0.11.1 (#145959 )

2024-04-03 02:16:13 +00:00

README.md

…

README.md

Flutter

Flutter is a new way to build high-performance, cross-platform mobile, web, and desktop apps. Flutter is optimized for today's — and tomorrow's — mobile and desktop devices. We are focused on low-latency input and high frame rates on all platforms.

See the getting started guide for information about using Flutter.