Tong Mu
8040ebc803
Correctly implement PlatformViews' cursors on Web (#174300)
Fix https://github.com/flutter/flutter/issues/174246
Before:
https://github.com/user-attachments/assets/33d2a476-d9c4-46e1-a5c5-ea8e602060d6
After:
https://github.com/user-attachments/assets/383e4a01-4b8e-4c0e-a5a4-fa0d1fc28b67
This PR is not a result of a thorough fix for mouse cursors on all
platforms, but simply matching the behavior of `SelectionArea` on Web to
that on non-Web.
A central question lies how a platform view widget should control the
mouse cursor. On the surface, the answer is simple: it doesn't, and let
the view content to control (hence the `MouseCursor.uncontrolled`
constant). But what if the empty region of the view content doesn't
control the cursor at all? This would be a problem even on non-Web,
because if neither the view content nor the view controls the cursor on
non-Web, then the user will find the cursor remaining the one used by
the last region, which would be different when entering and when
leaving, the same bug as
https://github.com/flutter/flutter/issues/174246 . On the other hand,
what is it supposed to fall back to if the view content doesn't define a
cursor? Is the default cursor the logically correct option? ...
I decided that I did not want to dig too much into the details, and
instead focus on this specific issue. I tried the repro app on macOS and
found that the empty region of `SelectionArea` falls back to the widget
behind it, the same behavior as `MouseCursor.defer`. Therefore in this
PR I made `MouseCursor.uncontrolled` essentially the same as `.defer` on
Web, matching the behavior across platforms.
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-09-21 03:52:34 +00:00
..
2025-07-07 17:58:32 +00:00
2025-08-04 22:32:22 +00:00
2025-08-04 22:32:22 +00:00
2025-07-30 18:40:09 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-08-14 18:06:57 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-08-04 22:32:22 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-09 21:22:48 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-08-08 18:47:17 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-08-11 15:27:56 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-08-22 22:38:17 +00:00
2025-08-12 22:07:18 +00:00
2025-08-08 18:47:17 +00:00
2025-08-14 19:53:20 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-08-15 22:40:14 +00:00
2025-09-21 03:52:34 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-08-14 18:06:57 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-06-25 19:12:23 +00:00
2025-08-14 19:53:20 +00:00
2025-07-07 17:58:32 +00:00
2025-07-30 18:40:09 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-08-14 19:53:20 +00:00
2025-08-15 22:40:14 +00:00
2025-08-04 22:32:22 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-09-04 18:27:19 +00:00
2025-08-29 01:11:25 +00:00
2025-08-04 22:32:22 +00:00
2025-08-27 22:17:05 +00:00
2025-07-07 17:58:32 +00:00
2025-09-17 17:50:04 +00:00
2025-07-07 17:58:32 +00:00
2025-08-27 22:17:05 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-08-04 22:32:22 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-09-19 18:43:11 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-08-07 19:30:24 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-14 22:49:04 +00:00
2025-07-14 22:49:04 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-08-04 22:32:22 +00:00
2025-07-07 17:58:32 +00:00
2025-07-31 16:06:07 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-08-04 22:32:22 +00:00
2025-05-29 17:30:32 +00:00
2025-08-04 22:32:22 +00:00
2025-08-04 22:32:22 +00:00
2025-07-07 17:58:32 +00:00
2025-09-02 20:25:08 +00:00
2025-05-27 19:39:24 +00:00
2025-07-07 17:58:32 +00:00
2025-08-08 18:47:17 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-09-04 21:05:27 +00:00
2025-06-12 21:26:00 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-08-04 22:32:22 +00:00
2025-07-07 17:58:32 +00:00
2025-08-04 22:32:22 +00:00
2025-08-27 08:17:40 +00:00
2025-08-04 22:32:22 +00:00
2025-07-07 17:58:32 +00:00
2025-08-04 22:32:22 +00:00
2025-09-12 22:19:41 +00:00
2025-09-05 21:15:21 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-08-04 22:32:22 +00:00
2025-08-04 22:32:22 +00:00
2025-07-07 17:58:32 +00:00
2025-08-04 22:32:22 +00:00
2025-08-04 22:32:22 +00:00
2025-08-04 22:32:22 +00:00
2025-08-04 22:32:22 +00:00
2025-08-04 22:32:22 +00:00
2025-08-04 22:32:22 +00:00
2025-08-15 22:40:14 +00:00
2025-08-04 22:32:22 +00:00
2025-07-07 17:58:32 +00:00
2025-05-23 00:02:01 +00:00
2025-09-12 22:19:41 +00:00
2025-08-04 22:32:22 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-08-27 22:17:05 +00:00
2025-07-07 17:58:32 +00:00
2025-08-26 05:11:45 +00:00
2025-07-07 17:58:32 +00:00
2025-07-08 17:18:58 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-23 23:56:48 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-08-14 19:53:20 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-07-07 17:58:32 +00:00
2025-08-04 17:54:53 +00:00
2025-07-07 17:58:32 +00:00