mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
f41c1644d8
Re-submit the changes to enable windows pre-push checks. This patch changes how `ci/bin/format.dart` generate diffs from `diff` and `patch` commands to `git diff` and `git apply` in order to have a common method for these operations on all platforms. Windows installations don't have diff and patch commands available by default and many implementations which provide such commands work differently than the UN*X tools. Git however works consistently across all platforms. Additionally, this patch also changes the python executable in some of the pre-push components affected by this to `vpython3` to continue the effort started at flutter/flutter#108474 and I also removed the `--no-sound-null-safety` parameter in the ci/format.sh, ci/format.bat files NOTE: Since the original patch caused some issues, I suggest that this should be tested more carefully before it is merged. ### Issues fixed by this PR * flutter/flutter#108122 * flutter/flutter#107920 * flutter/flutter#86506 * flutter/flutter#106615 ### [flutter/tests] repo impact None. writing and running engine tests. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
41 lines
1.4 KiB
Batchfile
41 lines
1.4 KiB
Batchfile
@ECHO off
|
|
REM Copyright 2013 The Flutter Authors. All rights reserved.
|
|
REM Use of this source code is governed by a BSD-style license that can be
|
|
REM found in the LICENSE file.
|
|
|
|
REM ---------------------------------- NOTE ----------------------------------
|
|
REM
|
|
REM Please keep the logic in this file consistent with the logic in the
|
|
REM `format.sh` script in the same directory to ensure that it continues to
|
|
REM work across all platforms!
|
|
REM
|
|
REM --------------------------------------------------------------------------
|
|
|
|
SETLOCAL ENABLEDELAYEDEXPANSION
|
|
|
|
FOR %%i IN ("%~dp0..\..") DO SET SRC_DIR=%%~fi
|
|
|
|
REM Test if Git is available on the Host
|
|
where /q git || ECHO Error: Unable to find git in your PATH. && EXIT /B 1
|
|
|
|
SET repo_dir=%SRC_DIR%\flutter
|
|
SET ci_dir=%repo_dir%\ci
|
|
|
|
REM Determine which platform we are on and use the right prebuilt Dart SDK
|
|
IF "%PROCESSOR_ARCHITECTURE%"=="AMD64" (
|
|
SET dart_sdk_path=%SRC_DIR%\flutter\prebuilts\windows-x64\dart-sdk
|
|
) ELSE IF "%PROCESSOR_ARCHITECTURE%"=="ARM64" (
|
|
SET dart_sdk_path=%SRC_DIR%\flutter\prebuilts\windows-arm64\dart-sdk
|
|
) ELSE (
|
|
ECHO "Windows x86 (32-bit) is not supported" && EXIT /B 1
|
|
)
|
|
|
|
SET dart=%dart_sdk_path%\bin\dart.exe
|
|
|
|
cd "%ci_dir%"
|
|
|
|
REM Do not use the CALL command in the next line to execute Dart. CALL causes
|
|
REM Windows to re-read the line from disk after the CALL command has finished
|
|
REM regardless of the ampersand chain.
|
|
"%dart%" --disable-dart-dev bin\format.dart %* & exit /B !ERRORLEVEL!
|