Ian Hickson f64bfba860 Tapping a ScrollView during overscroll got it stuck. (#9721) ...

Fixes https://github.com/flutter/flutter/issues/8476

More detailed list of changes in this patch:

* Replaced the didTouch special logic with more generic logic that
  uses Activities instead. Now instead when you tap down the
  Scrollable calls `hold()` which begins a HoldScrollActivity which is
  a hybrid of DragStartDetails and IdleScrollActivity and can be
  canceled. When you let go, it gets canceled and that goes ballistic.

* Make DragGestureRecognizer more aggressive about grabbing pointers,
  otherwise a second pointer in a situation with competing horizontal
  and vertical recognizers always gets taken by the other one.

* Fixed the _GestureSemantics widget to call the "down" callbacks so
  that it follows the same pattern as "real" interactions.

* Added tests for the above.

* Added a hashCode to ScrollActivity.toString (and subclasses).

* Added a toString to ScrollDragController, and include it in
  DragScrollActivity's toString.

* s/coorindator/coordinator/

* Add a comment in DragStartDetails to distinguish it from the
  otherwise identical DragDownDetails, so we're not tempted to merge
  them.

2017-05-02 16:31:11 -07:00

..

align_test.dart

…

animated_container_test.dart

BoxDecoration API changes: backgroundColor -> color et al (#9648)

2017-04-27 14:19:01 -07:00

animated_cross_fade_test.dart

More const immutable classes (#9544)

2017-04-23 22:37:29 +02:00

animated_list_test.dart

Flush microtasks after transient callbacks are run. (#9702)

2017-05-02 09:27:53 -07:00

animated_positioned_test.dart

Move Point to Offset (#9277)

2017-04-12 15:06:12 -07:00

animated_size_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

app_overrides_test.dart

Document the buildTransitions() method (#9182)

2017-04-04 17:18:16 -07:00

aspect_ratio_test.dart

…

async_test.dart

More const immutable classes (#9544)

2017-04-23 22:37:29 +02:00

banner_test.dart

…

baseline_test.dart

Constants! Constants everywhere! (#9286)

2017-04-07 12:24:32 -07:00

binding_test.dart

Make naming consistent across channel APIs (#9270)

2017-04-18 15:23:15 +02:00

box_decoration_test.dart

BoxDecoration API changes: backgroundColor -> color et al (#9648)

2017-04-27 14:19:01 -07:00

box_sliver_mismatch_test.dart

The const will continue until morale improves (#9536)

2017-04-21 14:59:24 -07:00

build_scope_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

center_test.dart

Constants! Constants everywhere! (#9286)

2017-04-07 12:24:32 -07:00

clamp_overscrolls_test.dart

Move Point to Offset (#9277)

2017-04-12 15:06:12 -07:00

clip_test.dart

Move Point to Offset (#9277)

2017-04-12 15:06:12 -07:00

column_test.dart

…

container_test.dart

BoxDecoration API changes: backgroundColor -> color et al (#9648)

2017-04-27 14:19:01 -07:00

coordinates_test.dart

Move Point to Offset (#9277)

2017-04-12 15:06:12 -07:00

custom_multi_child_layout_test.dart

…

custom_paint_test.dart

Deploy @immutable in more places (#9462)

2017-04-19 09:30:43 -07:00

custom_single_child_layout_test.dart

…

date_picker_test.dart

…

default_text_style_test.dart

fix DefaultTextStyle not notifying updates for some changes (#9416)

2017-04-16 19:01:37 -07:00

dismissible_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

dispose_ancestor_lookup_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

draggable_test.dart

BoxDecoration API changes: backgroundColor -> color et al (#9648)

2017-04-27 14:19:01 -07:00

drawer_test.dart

BoxDecoration API changes: backgroundColor -> color et al (#9648)

2017-04-27 14:19:01 -07:00

ensure_visible_test.dart

BoxDecoration API changes: backgroundColor -> color et al (#9648)

2017-04-27 14:19:01 -07:00

fitted_box_test.dart

Move Point to Offset (#9277)

2017-04-12 15:06:12 -07:00

flex_test.dart

BoxDecoration API changes: backgroundColor -> color et al (#9648)

2017-04-27 14:19:01 -07:00

flow_test.dart

BoxDecoration API changes: backgroundColor -> color et al (#9648)

2017-04-27 14:19:01 -07:00

focus_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

form_test.dart

WidgetTester enterText() and showKeyboard() can specify an EditableText ancestor (#9398)

2017-04-14 15:41:30 -07:00

fractionally_sized_box_test.dart

Move Point to Offset (#9277)

2017-04-12 15:06:12 -07:00

framework_test.dart

New Placeholder widget. (#9565)

2017-04-24 14:06:07 -07:00

gesture_detector_test.dart

BoxDecoration API changes: backgroundColor -> color et al (#9648)

2017-04-27 14:19:01 -07:00

global_keys_duplicated_test.dart

Constants! Constants everywhere! (#9286)

2017-04-07 12:24:32 -07:00

global_keys_moving_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

grid_paper_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

grid_view_layout_test.dart

Constants! Constants everywhere! (#9286)

2017-04-07 12:24:32 -07:00

grid_view_test.dart

BoxDecoration API changes: backgroundColor -> color et al (#9648)

2017-04-27 14:19:01 -07:00

heroes_test.dart

More const immutable classes (#9544)

2017-04-23 22:37:29 +02:00

hit_testing_test.dart

Move Point to Offset (#9277)

2017-04-12 15:06:12 -07:00

hyperlink_test.dart

Move Point to Offset (#9277)

2017-04-12 15:06:12 -07:00

icon_test.dart

Constants! Constants everywhere! (#9286)

2017-04-07 12:24:32 -07:00

image_resolution_test.dart

Rename ImageFit to BoxFit (#8871)

2017-03-17 15:21:55 -07:00

image_test.dart

Image color blend mode (#9486)

2017-04-19 17:46:00 -07:00

implicit_animations_test.dart

BoxDecoration API changes: backgroundColor -> color et al (#9648)

2017-04-27 14:19:01 -07:00

independent_widget_layout_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

inherited_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

init_state_test.dart

…

key_test.dart

…

layout_builder_and_global_keys_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

layout_builder_and_parent_data_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

layout_builder_and_state_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

layout_builder_mutations_test.dart

add @required when there's an assert not null (#9124)

2017-03-31 18:34:13 +02:00

layout_builder_test.dart

…

linked_scroll_view_test.dart

Add NestedScrollView (#9640)

2017-04-27 12:29:40 -07:00

list_view_builder_test.dart

Constants! Constants everywhere! (#9286)

2017-04-07 12:24:32 -07:00

list_view_correction_test.dart

Handle ListView item size changes that cause underflow (#9586)

2017-04-26 10:44:35 -07:00

list_view_fling_test.dart

…

list_view_horizontal_test.dart

…

list_view_misc_test.dart

BoxDecoration API changes: backgroundColor -> color et al (#9648)

2017-04-27 14:19:01 -07:00

list_view_relayout_test.dart

ListView.Builder() handles appends when scrolled to the end (#9533)

2017-04-21 14:07:41 -07:00

list_view_test.dart

SliverChildDelegate should know which children are live (#9073)

2017-03-29 22:54:03 -07:00

list_view_vertical_test.dart

…

list_view_viewporting_test.dart

BoxDecoration API changes: backgroundColor -> color et al (#9648)

2017-04-27 14:19:01 -07:00

list_view_with_inherited_test.dart

…

listener_test.dart

Constants! Constants everywhere! (#9286)

2017-04-07 12:24:32 -07:00

listview_end_append_test.dart

ListView.Builder() handles appends when scrolled to the end (#9533)

2017-04-21 14:07:41 -07:00

locale_query_test.dart

…

media_query_test.dart

MediaQuery.of shouldn't give a default return value (#9596)

2017-04-27 15:02:59 -07:00

modal_barrier_test.dart

Loosen the constraints for Stack non-positioned children. (#9581)

2017-04-25 15:06:02 -07:00

multichild_test.dart

…

navigator_and_layers_test.dart

Don't paint on unattached layers. (#9519)

2017-04-21 13:39:55 -07:00

navigator_test.dart

BoxDecoration API changes: backgroundColor -> color et al (#9648)

2017-04-27 14:19:01 -07:00

nested_scroll_view_test.dart

Add NestedScrollView (#9640)

2017-04-27 12:29:40 -07:00

notification_test.dart

…

overflow_box_test.dart

Move Point to Offset (#9277)

2017-04-12 15:06:12 -07:00

overlay_test.dart

…

overscroll_indicator_test.dart

BoxDecoration API changes: backgroundColor -> color et al (#9648)

2017-04-27 14:19:01 -07:00

page_forward_transitions_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

page_storage_test.dart

…

page_transitions_test.dart

BoxDecoration API changes: backgroundColor -> color et al (#9648)

2017-04-27 14:19:01 -07:00

page_view_test.dart

BoxDecoration API changes: backgroundColor -> color et al (#9648)

2017-04-27 14:19:01 -07:00

pageable_list_test.dart

…

parent_data_test.dart

…

performance_overlay_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

placeholder_test.dart

New Placeholder widget. (#9565)

2017-04-24 14:06:07 -07:00

positioned_test.dart

Support chaining await calls on controllers (#9389)

2017-04-14 18:27:31 -07:00

raw_keyboard_listener_test.dart

Flush microtasks after transient callbacks are run. (#9702)

2017-05-02 09:27:53 -07:00

reassemble_test.dart

Constants! Constants everywhere! (#9286)

2017-04-07 12:24:32 -07:00

remember_scroll_position_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

render_object_widget_test.dart

BoxDecoration API changes: backgroundColor -> color et al (#9648)

2017-04-27 14:19:01 -07:00

reparent_state_harder_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

reparent_state_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

reparent_state_with_layout_builder_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

rotated_box_test.dart

Move Point to Offset (#9277)

2017-04-12 15:06:12 -07:00

routes_test.dart

prefer_final_fields (#8967)

2017-03-29 21:21:46 +02:00

row_test.dart

…

run_app_test.dart

Constants! Constants everywhere! (#9286)

2017-04-07 12:24:32 -07:00

scroll_behavior_test.dart

Refactor scrolling code to prepare for nested scrolling (#9575)

2017-04-24 23:32:55 -07:00

scroll_controller_test.dart

…

scroll_events_test.dart

Tapping a ScrollView during overscroll got it stuck. (#9721)

2017-05-02 16:31:11 -07:00

scroll_interaction_test.dart

Move Point to Offset (#9277)

2017-04-12 15:06:12 -07:00

scroll_notification_test.dart

Move Point to Offset (#9277)

2017-04-12 15:06:12 -07:00

scroll_simulation_test.dart

…

scroll_view_test.dart

Adjust the defaults behaviour of scroll views. (#9679)

2017-05-02 09:14:50 -07:00

scrollable_dispose_test.dart

…

scrollable_fling_test.dart

Fix tests to use Ahem, and helpful changes around that (#9332)

2017-04-12 13:33:02 -07:00

scrollable_grid_test.dart

ListView.Builder() handles appends when scrolled to the end (#9533)

2017-04-21 14:07:41 -07:00

scrollable_list_hit_testing_test.dart

Move Point to Offset (#9277)

2017-04-12 15:06:12 -07:00

scrollable_of_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

scrollable_test.dart

Tapping a ScrollView during overscroll got it stuck. (#9721)

2017-05-02 16:31:11 -07:00

semantics_1_test.dart

Constants! Constants everywhere! (#9286)

2017-04-07 12:24:32 -07:00

semantics_2_test.dart

Constants! Constants everywhere! (#9286)

2017-04-07 12:24:32 -07:00

semantics_3_test.dart

Constants! Constants everywhere! (#9286)

2017-04-07 12:24:32 -07:00

semantics_4_test.dart

Rename Stack.sizing to Stack.fit (#9615)

2017-04-26 11:12:38 -07:00

semantics_5_test.dart

Rename Stack.sizing to Stack.fit (#9615)

2017-04-26 11:12:38 -07:00

semantics_7_test.dart

Rename Stack.sizing to Stack.fit (#9615)

2017-04-26 11:12:38 -07:00

semantics_8_test.dart

Constants! Constants everywhere! (#9286)

2017-04-07 12:24:32 -07:00

semantics_debugger_test.dart

Move Point to Offset (#9277)

2017-04-12 15:06:12 -07:00

semantics_test.dart

…

semantics_tester.dart

Loosen the constraints for Stack non-positioned children. (#9581)

2017-04-25 15:06:02 -07:00

set_state_1_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

set_state_2_test.dart

Constants! Constants everywhere! (#9286)

2017-04-07 12:24:32 -07:00

set_state_3_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

set_state_4_test.dart

Constants! Constants everywhere! (#9286)

2017-04-07 12:24:32 -07:00

shader_mask_test.dart

…

single_child_scroll_view_test.dart

BoxDecoration API changes: backgroundColor -> color et al (#9648)

2017-04-27 14:19:01 -07:00

size_changed_layout_notification_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

sized_box_test.dart

…

sliver_fill_remaining_test.dart

Constants! Constants everywhere! (#9286)

2017-04-07 12:24:32 -07:00

sliver_fill_viewport_test.dart

Rename SliverFill to SliverFillViewport and add SliverFillRemaining (#9194)

2017-04-05 12:27:59 -07:00

slivers_appbar_floating_test.dart

Refactor scrolling code to prepare for nested scrolling (#9575)

2017-04-24 23:32:55 -07:00

slivers_appbar_pinned_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

slivers_appbar_scrolling_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

slivers_block_global_key_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

slivers_block_test.dart

Move Point to Offset (#9277)

2017-04-12 15:06:12 -07:00

slivers_evil_test.dart

Refactor scrolling code to prepare for nested scrolling (#9575)

2017-04-24 23:32:55 -07:00

slivers_padding_test.dart

Move Point to Offset (#9277)

2017-04-12 15:06:12 -07:00

slivers_protocol_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

slivers_test.dart

Move Point to Offset (#9277)

2017-04-12 15:06:12 -07:00

stack_test.dart

BoxDecoration API changes: backgroundColor -> color et al (#9648)

2017-04-27 14:19:01 -07:00

state_setting_in_scrollables_test.dart

BoxDecoration API changes: backgroundColor -> color et al (#9648)

2017-04-27 14:19:01 -07:00

stateful_component_test.dart

…

stateful_components_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

states.dart

…

status_transitions_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

syncing_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

table_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

test_widgets.dart

BoxDecoration API changes: backgroundColor -> color et al (#9648)

2017-04-27 14:19:01 -07:00

text_formatter_test.dart

Create a text validator/formatter mechanism (#9535)

2017-04-28 15:33:38 -07:00

text_test.dart

More const immutable classes (#9544)

2017-04-23 22:37:29 +02:00

ticker_provider_test.dart

More const immutable classes (#9544)

2017-04-23 22:37:29 +02:00

title_test.dart

…

transform_test.dart

BoxDecoration API changes: backgroundColor -> color et al (#9648)

2017-04-27 14:19:01 -07:00

transitions_test.dart

BoxDecoration API changes: backgroundColor -> color et al (#9648)

2017-04-27 14:19:01 -07:00

unique_widget_test.dart

make @immutable const classes (#9532)

2017-04-21 23:09:42 +02:00

wrap_test.dart

Move Point to Offset (#9277)

2017-04-12 15:06:12 -07:00