Jonah Williams 7c5060aa68 [Impeller] defer construction of VkCommandBuffer until encoding begins. (flutter/engine#43605) ...

VkCommandBuffers are allocated out of a thread local VkCommandPool. THis command buffer is only safe to use on the thread which allocates it.

We'd like to attempt concurrent encoding on Vulkan like we've done for iOS, which means the worker threads will be accessing the VkCommandBuffer. In order for this to be safe, the VkCommandBuffer must be allocated out of a VkCommandPool from that worker thread. As a simple fix, we make the Impeller CommandBuffer defer construction of the VkCommandBuffer object, allowing us to record impeller commands on the raster thread, move the command buffer to a worker thread, create the VkCommandBuffer, and then begin encoding.

2023-07-14 21:21:02 +00:00

..

src/flutter

[Impeller] defer construction of VkCommandBuffer until encoding begins. (flutter/engine#43605)

2023-07-14 21:21:02 +00:00