mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
99ee3c2b0d
This issue would only manifest when a custom task runner was being used with a custom compositor. Both were tested separately but not together. A new test has been added for this. We still create the GPU thread merger unnecessarily but I can patch that later. I also cleaned up the existing custom task runner test to not submit tasks on a dead engine as they just log errors unnecessarily. Filed new: https://github.com/flutter/flutter/issues/38844
81 lines
2.2 KiB
C++
81 lines
2.2 KiB
C++
// Copyright 2013 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "flutter/shell/platform/embedder/embedder_task_runner.h"
|
|
|
|
#include "flutter/fml/message_loop_impl.h"
|
|
#include "flutter/fml/message_loop_task_queues.h"
|
|
|
|
namespace flutter {
|
|
|
|
EmbedderTaskRunner::EmbedderTaskRunner(DispatchTable table)
|
|
: TaskRunner(nullptr /* loop implemenation*/),
|
|
dispatch_table_(std::move(table)),
|
|
placeholder_id_(
|
|
fml::MessageLoopTaskQueues::GetInstance()->CreateTaskQueue()) {
|
|
FML_DCHECK(dispatch_table_.post_task_callback);
|
|
FML_DCHECK(dispatch_table_.runs_task_on_current_thread_callback);
|
|
}
|
|
|
|
EmbedderTaskRunner::~EmbedderTaskRunner() = default;
|
|
|
|
void EmbedderTaskRunner::PostTask(fml::closure task) {
|
|
PostTaskForTime(task, fml::TimePoint::Now());
|
|
}
|
|
|
|
void EmbedderTaskRunner::PostTaskForTime(fml::closure task,
|
|
fml::TimePoint target_time) {
|
|
if (!task) {
|
|
return;
|
|
}
|
|
|
|
uint64_t baton = 0;
|
|
|
|
{
|
|
// Release the lock before the jump via the dispatch table.
|
|
std::scoped_lock lock(tasks_mutex_);
|
|
baton = ++last_baton_;
|
|
pending_tasks_[baton] = task;
|
|
}
|
|
|
|
dispatch_table_.post_task_callback(this, baton, target_time);
|
|
}
|
|
|
|
void EmbedderTaskRunner::PostDelayedTask(fml::closure task,
|
|
fml::TimeDelta delay) {
|
|
PostTaskForTime(task, fml::TimePoint::Now() + delay);
|
|
}
|
|
|
|
bool EmbedderTaskRunner::RunsTasksOnCurrentThread() {
|
|
return dispatch_table_.runs_task_on_current_thread_callback();
|
|
}
|
|
|
|
bool EmbedderTaskRunner::PostTask(uint64_t baton) {
|
|
fml::closure task;
|
|
|
|
{
|
|
std::scoped_lock lock(tasks_mutex_);
|
|
auto found = pending_tasks_.find(baton);
|
|
if (found == pending_tasks_.end()) {
|
|
FML_LOG(ERROR) << "Embedder attempted to post an unknown task.";
|
|
return false;
|
|
}
|
|
task = found->second;
|
|
pending_tasks_.erase(found);
|
|
|
|
// Let go of the tasks mutex befor executing the task.
|
|
}
|
|
|
|
FML_DCHECK(task);
|
|
task();
|
|
return true;
|
|
}
|
|
|
|
// |fml::TaskRunner|
|
|
fml::TaskQueueId EmbedderTaskRunner::GetTaskQueueId() {
|
|
return placeholder_id_;
|
|
}
|
|
|
|
} // namespace flutter
|