mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00

History

Bernardo Ferrari 2afec776c9

Make UnderlineInputBorder consistent (#124153 )

This was easy to implement. I like the result, I think `borderRadius.zero` -> `borderRadius.circular` makes a nice transition, and many places (like macOS) use an effect similar to this PR, while Google doesn't use anywhere (yet). I'm curious if it is going to break goldens or google testing.

<img width="954" alt="ttt" src="https://user-images.githubusercontent.com/351125/229918871-9f2ab851-6b41-44f5-80b9-c7928a8c0014.png">

What do you think? cc @HansMuller @gspencergoog. Is this something you want, should I ask the community, or do you prefer the current one?

Side effects:
- This makes strokeAlign work with `UnderlineInputBorder` (TODO: fix `drawLine` when borderRadius is zero).
- This is faster than the current implementation (clip is slow on Skia). ð 
- We could just call `BoxBorder._paintNonUniformBorder` (if it weren't private). Single LOC implementation.
- Web does this by default:
![image](https://user-images.githubusercontent.com/351125/233448671-90ce62ff-be91-40ca-8007-e82b57f3272e.png)
- Apparently no tests fail and most usages around (via code search) seem to be without a borderRadius.

2023-11-15 23:06:57 +00:00

lib

Make UnderlineInputBorder consistent (#124153 )

2023-11-15 23:06:57 +00:00

test

Make UnderlineInputBorder consistent (#124153 )

2023-11-15 23:06:57 +00:00

test_fixes

Deprecates onWillAccept and onAccept callbacks in DragTarget. (#133691 )

2023-11-10 22:47:22 +00:00

test_private

Pin package:web 0.4.0 (#138428 )

2023-11-15 15:03:21 -08:00

test_profile

…

test_release

…

analysis_options.yaml

…

build.yaml

…

dart_test.yaml

…

LICENSE

…

pubspec.yaml

Pin package:web 0.4.0 (#138428 )

2023-11-15 15:03:21 -08:00

README.md

…

README.md

Flutter

Flutter is a new way to build high-performance, cross-platform mobile, web, and desktop apps. Flutter is optimized for today's — and tomorrow's — mobile and desktop devices. We are focused on low-latency input and high frame rates on all platforms.

See the getting started guide for information about using Flutter.