mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
75c60cf9f1
Reverts flutter/engine#50028 Initiated by: jonahwilliams This change reverts the following previous change: Original Description: Once a hardware buffer has been imported (a VkImage created for it), we don't ever need to re-create a VkImage, even when the contents change. The same hardware buffer can be identified by ID. Part of https://github.com/flutter/flutter/issues/142153 Otherwise we spend a lot of time re-creating VkImages:  Draft is here, but is currently leaky: https://github.com/flutter/engine/pull/50028 We only need something like a LRU with the max image size (seems to be 3 for me). This does log locally that I'm not calling close correctly: ``` E/flutter ( 5580): [ERROR:flutter/shell/platform/android/image_external_texture_vk.cc(51)] Size: 3 W/System ( 5580): A resource failed to call HardwareBuffer.close. W/System ( 5580): A resource failed to call HardwareBuffer.close. W/System ( 5580): A resource failed to call HardwareBuffer.close. W/System ( 5580): A resource failed to call HardwareBuffer.close. W/System ( 5580): A resource failed to call HardwareBuffer.close. W/System ( 5580): A resource failed to call HardwareBuffer.close. W/System ( 5580): A resource failed to call HardwareBuffer.close. W/System ( 5580): A resource failed to call HardwareBuffer.close. W/System ( 5580): A resource failed to call HardwareBuffer.close. W/System ( 5580): A resource failed to call HardwareBuffer.close. W/System ( 5580): A resource failed to call HardwareBuffer.close. W/System ( 5580): A resource failed to call HardwareBuffer.close. W/System ( 5580): A resource failed to call HardwareBuffer.close. W/System ( 5580): A resource failed to call HardwareBuffer.close. W/System ( 5580): A resource failed to call HardwareBuffer.close. W/System ( 5580): A resource failed to call HardwareBuffer.close. W/System ( 5580): A resource failed to call HardwareBuffer.close. W/System ( 5580): A resource failed to call HardwareBuffer.close. W/System ( 5580): A resource failed to call HardwareBuffer.close. W/System ( 5580): A resource failed to call HardwareBuffer.close. W/System ( 5580): A resource failed to call HardwareBuffer.close. W/System ( 5580): A resource failed to call HardwareBuffer.close. ``` FYI @johnmccutchan