mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
731d2d9e77
This includes a fix for a race seen in EmbedderTest.PlatformThreadIsolatesWithCustomPlatformTaskRunner The implementaion of MergedPlatformUIThread::kMergeAfterLaunch required changing the interface of the TaskObserverAdd/TaskObserverRemove callbacks so that TaskObserverAdd returned the TaskQueueId where the observer was added. That TaskQueueId would later be given to TaskObserverRemove. The original implementation of this PR updated the embedder library's implementation of TaskObserverAdd to return TaskQueueId::kInvalid to signal that the observer was not added. However, this conflicted with the embedder's EmbedderTaskRunner, whose implementation of GetTaskQueueId returns TaskQueueId::kInvalid as a placeholder. This PR reverts the embedder's TaskObserverAdd/TaskObserverRemove to the original implementation which adds the observer to the current thread's message loop and does not call GetTaskQueueId. See https://github.com/flutter/flutter/issues/167418
43 lines
1.1 KiB
C++
43 lines
1.1 KiB
C++
// Copyright 2013 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef FLUTTER_FML_TASK_QUEUE_ID_H_
|
|
#define FLUTTER_FML_TASK_QUEUE_ID_H_
|
|
|
|
#include "flutter/fml/logging.h"
|
|
|
|
namespace fml {
|
|
|
|
/**
|
|
* `MessageLoopTaskQueues` task dispatcher's internal task queue identifier.
|
|
*/
|
|
class TaskQueueId {
|
|
public:
|
|
/// This constant indicates whether a task queue has been subsumed by a task
|
|
/// runner.
|
|
static const size_t kUnmerged;
|
|
|
|
/// This constant indicates an invalid task queue. Used in embedder
|
|
/// supplied task runners not associated with a task queue.
|
|
static const size_t kInvalid;
|
|
|
|
/// Intializes a task queue with the given value as it's ID.
|
|
explicit TaskQueueId(size_t value) : value_(value) {}
|
|
|
|
static TaskQueueId Invalid() { return TaskQueueId(kInvalid); }
|
|
|
|
operator size_t() const { // NOLINT(google-explicit-constructor)
|
|
return value_;
|
|
}
|
|
|
|
bool is_valid() const { return value_ != kInvalid; }
|
|
|
|
private:
|
|
size_t value_ = kUnmerged;
|
|
};
|
|
|
|
} // namespace fml
|
|
|
|
#endif // FLUTTER_FML_TASK_QUEUE_ID_H_
|