mirror of
https://github.com/flutter/flutter.git
synced 2026-02-05 19:28:51 +08:00
This PR introduces a new feature flag called `lldb-debugging`, which is turned on by default. When this feature is turned on, if deploying to a physical iOS 17+ device with Xcode 26+, it will use a mixture of `devicectl` and `lldb` to install, launch, and debug the app. If LLDB fails, it will fallback to use Xcode automation. If LLDB times out, it will warn the user they may want to disable it. If LLDB is disabled, it will use Xcode automation. This PR also adds analytics to track what deployment method is used and if it's successful. Part 2 and 3 of https://github.com/flutter/flutter/issues/173416. Fixes https://github.com/flutter/flutter/issues/144218. Fixes https://github.com/flutter/flutter/issues/133465. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
94 lines
2.5 KiB
Dart
94 lines
2.5 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:meta/meta.dart';
|
|
|
|
import 'base/platform.dart';
|
|
import 'features.dart';
|
|
import 'flutter_features_config.dart';
|
|
import 'version.dart';
|
|
|
|
@visibleForTesting
|
|
mixin FlutterFeatureFlagsIsEnabled implements FeatureFlags {
|
|
@protected
|
|
Platform get platform;
|
|
|
|
@override
|
|
bool get isLinuxEnabled => isEnabled(flutterLinuxDesktopFeature);
|
|
|
|
@override
|
|
bool get isMacOSEnabled => isEnabled(flutterMacOSDesktopFeature);
|
|
|
|
@override
|
|
bool get isWebEnabled => isEnabled(flutterWebFeature);
|
|
|
|
@override
|
|
bool get isWindowsEnabled => isEnabled(flutterWindowsDesktopFeature);
|
|
|
|
@override
|
|
bool get isAndroidEnabled => isEnabled(flutterAndroidFeature);
|
|
|
|
@override
|
|
bool get isIOSEnabled => isEnabled(flutterIOSFeature);
|
|
|
|
@override
|
|
bool get isFuchsiaEnabled => isEnabled(flutterFuchsiaFeature);
|
|
|
|
@override
|
|
bool get areCustomDevicesEnabled => isEnabled(flutterCustomDevicesFeature);
|
|
|
|
@override
|
|
bool get isCliAnimationEnabled {
|
|
if (platform.environment['TERM'] == 'dumb') {
|
|
return false;
|
|
}
|
|
return isEnabled(cliAnimation);
|
|
}
|
|
|
|
@override
|
|
bool get isNativeAssetsEnabled => isEnabled(nativeAssets);
|
|
|
|
@override
|
|
bool get isSwiftPackageManagerEnabled => isEnabled(swiftPackageManager);
|
|
|
|
@override
|
|
bool get isOmitLegacyVersionFileEnabled => isEnabled(omitLegacyVersionFile);
|
|
|
|
@override
|
|
bool get isWindowingEnabled => isEnabled(windowingFeature);
|
|
|
|
@override
|
|
bool get isLLDBDebuggingEnabled => isEnabled(lldbDebugging);
|
|
}
|
|
|
|
interface class FlutterFeatureFlags extends FeatureFlags with FlutterFeatureFlagsIsEnabled {
|
|
FlutterFeatureFlags({
|
|
required FlutterVersion flutterVersion,
|
|
required FlutterFeaturesConfig featuresConfig,
|
|
required this.platform,
|
|
}) : _flutterVersion = flutterVersion,
|
|
_featuresConfig = featuresConfig;
|
|
|
|
final FlutterVersion _flutterVersion;
|
|
final FlutterFeaturesConfig _featuresConfig;
|
|
|
|
@override
|
|
@protected
|
|
final Platform platform;
|
|
|
|
@override
|
|
bool isEnabled(Feature feature) {
|
|
final String currentChannel = _flutterVersion.channel;
|
|
final FeatureChannelSetting featureSetting = feature.getSettingForChannel(currentChannel);
|
|
|
|
// If unavailable, then no setting can enable this feature.
|
|
if (!featureSetting.available) {
|
|
return false;
|
|
}
|
|
|
|
// Otherwise, read it from environment variable > project manifest > global config
|
|
return _featuresConfig.isEnabled(feature) ?? featureSetting.enabledByDefault;
|
|
}
|
|
}
|