mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
59d8010db5
Fixes #174150 This PR updates the Android `AccessibilityBridge` to use the `headingLevel` property from `SemanticsNode` to determine if a node should be marked as a heading for accessibility purposes. Previously, the `IS_HEADER` flag was used. Now, a node is considered a heading if `headingLevel > 0`. This aligns with the common accessibility pattern where heading levels (like H1, H2, etc.) define the structure. The following changes were made: - Modified `AccessibilityBridge.java` to set the heading status based on `semanticsNode.headingLevel > 0` for Android API level 28 and above. - Added `headingLevel` to the `SemanticsNode` data structure in Java and its serialization/deserialization logic. - Updated the C++ `PlatformViewAndroidDelegate` to include `headingLevel` when serializing `SemanticsNode` data. - Increased `kBytesPerNode` in `platform_view_android_delegate.h` to account for the new `headingLevel` field. - Added tests in `AccessibilityBridgeTest.java` to verify the new heading logic: - Nodes with `headingLevel = 0` are not headings. - Nodes with `headingLevel > 0` are headings. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Flutter Engine
Setting up the Engine development environment
See here
gclient bootstrap
Flutter engine uses gclient to manage dependencies.
If you've already cloned the flutter repository: