mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
588d429c65
The driver on PIxel 10 requires Flutter to set the `engine` version to something higher than 1.0. We had previous set the application version without effect. With this change, I see we can get a valid vulkan context. - ran some testing against reported errors (saw none) - compiled and ran wonderous with validation layers (runs) - still researching towards: #179812 > On a pixel 10, the Vulkan engine version must be bumped up past 1.0 and any other additional checks gating Vulkan removed. It must be confirmed that Impeller is able to create a Vulkan context. Pixel 10 gets a Vulkan context with just the engine version bump. > The usual sample applications must render accurately. wonderous and failing code passes and renders correctly > The reduced test cases in the internal doc must be tested. it does. > If testing is successful, the engine version update may be committed. This is necessary for enabling Vulkan on Pixel 10 but not sufficient to ensure stability of newer Vulkan enabled Impeller applications on Pixel 10 devices that have not yet been updated. This PR does that. > Impeller must detect the driver version and self-reject Vulkan on device older than the current Pixel 10 GPU driver version. The IHV reports that a safe conservative driver version is >= 25.1 and any verification must happen on versions past this. Impeller should still base its checks on the driver version that we verify correctness on. What we have today works well and it is not advised to introduce instability for the sake of enabling Vulkan on this device. Done - driver_version appears to be a build number, so monotonically increasing.