mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
65701bd31b
- The
[shader](3b20617345/engine/src/flutter/lib/ui/fixtures/shaders/general_shaders/vec3_uniform.frag)
has `uniform vec3[4] color_array;` and sets `fragColor =
vec4(color_array[3].xyz, 1);`. Update the test to use the correct
indexes for `color_array[3]`: 9, 10, 11 instead of 12, 13, 14.
- Skip the test for metal. Metal seems like it has some weird index
padding issue. From testing it out:
- `color_array[0].xyz` is set when setting indexes 0, 1, 2, as expected.
- `color_array[1].xyz` should use indexes 3, 4, 5. But it seems to use
indexes 4, 5, 6. Maybe there's some incorrect math making it skip index
3.
- `color_array[2].xyz` should use indexes 6, 7, 8. But it seems to use
indexes 8, 9, 10. Maybe there's some incorrect math making it skip
indexes 3 and 7.
- `color_array[3].xyz` should use indexes 9, 10, 11. But it seems to be
impossible to set. Maybe it skips indexes 3, 7, and 11 and then tries to
look at out-of-bounds indexes 12, 13, 14?
- Fix incorrect logic in the `_expectShaderRendersColor()` method.
- The 4 bytes for each pixel of an image are in the format `0xRRGGBBAA`.
- This method used to use `renderedBytes.buffer.asUint32List()`. This
reads 4 bytes to a Uint32, but uses `Endian.host` endianness. Maybe this
differs on different platforms, but on my Mac this is little endian. So
the image's `0xRRGGBBAA` bytes are read into a Uint32 as `0xAABBGGRR`.
- This is then compared to the target `Color.value`, which is in ARGB32
format: `0xAARRGGBB`.
- So it's comparing the each image's pixel as `0xAABBGGRR` to the target
color as `0xAARRGGBB`. It switches the RR and BB channels for every
comparison.
- This did not result in any test failures because
`_expectShaderRendersColor()` is only ever used as a helper function for
`_expectShaderRendersGreen()` and `_expectShaderRendersBlack()`. And
(un)luckily, those perfectly ignore the RR and BB channels.
- Fix the logic by reading each pixel's bytes with separate `getUint8()`
calls and parsing them into a `Color` with `fromARGB()`, using the
correct byte offsets for each channel.
Partially addresses #180932. Re-enables the test for Vulkan, but it's
still disabled for Metal.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md