mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
4c30aee50a
Reverts: flutter/engine#53072 Initiated by: jason-simmons Reason for reverting: compilation errors on iOS targets ``` FlutterPlatformViews_Internal.mm:277:10: error: ARC forbids explicit message send of 'dealloc' 277 | [super dealloc]; | ~~~~~ ^ ``` (see https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8746006425774972161/+/u/build_ci_ios_debug_unopt_sim_flutter_testing_scenario_app_flutter_shell_platform_darwin_ios:ios_test_flutter/st Original PR Author: hellohuanlin Reviewed By: {cbracken, jonahwilliams} This change reverts the following previous change: This PR uses `CAShapeLayer` as the mask to avoid software rendering. I kept `UIView` as the mask, so that we can measure just the improvement related to avoiding software rendering. This also allows me to land this change sooner. I created [a separate issue](https://github.com/flutter/flutter/issues/149212) to track removing UIView as the mask. Note: the previous behavior seems to be incorrect (or at least not pixel perfect). This PR fixed it. See comments. See design doc: https://docs.google.com/document/d/1TqG_N4GK_qctuk73Gk3zOdAiILUrwMqxoCMgroK_AeA/edit?resourcekey=0-jUiidfzIS642ngG2w9vSUA&tab=t.0 *List which issues are fixed by this PR. You must list at least one issue.* Fixes https://github.com/flutter/flutter/issues/142813 Fixes https://github.com/flutter/flutter/issues/142830 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style