mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00

History

Fix TabBar tab icons not respecting custom IconTheme (#157724 )

Fixes [TabBar ignores Theme's iconTheme.size](https://github.com/flutter/flutter/issues/155518)

### Description

When `ThemeData.IconTheme`  with color and size, is provided, it can override the default `Tab` icon color and size. 

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(
        iconTheme: const IconThemeData(color: Colors.amber, size: 40),
      ),
      home: const Scaffold(
        body: SafeArea(
          child: DefaultTabController(
            length: 2,
            child: Column(
              children: [
                TabBar(
                  tabs: [
                    Tab(icon: Icon(Icons.backpack_outlined), text: 'Backpack'),
                    Tab(icon: Icon(Icons.map_outlined), text: 'Map'),
                  ],
                  overlayColor: WidgetStatePropertyAll(Colors.transparent),
                ),
                Expanded(
                  child: TabBarView(
                    children: [
                      Icon(Icons.backpack_outlined),
                      Icon(Icons.map_outlined),
                    ],
                  ),
                ),
              ],
            ),
          ),
        ),
      ),
    );
  }
}
```

</details>

---

<img width="666" alt="Screenshot 2024-10-28 at 16 25 06" src="https://github.com/user-attachments/assets/56d31115-7ee9-4378-9811-75a3a2a4ce0f">

<img width="666" alt="Screenshot 2024-10-28 at 16 24 52" src="https://github.com/user-attachments/assets/ab8a3e4b-e912-40ac-b249-6358492581e0">

2024-10-29 10:51:38 +00:00

lib

Fix TabBar tab icons not respecting custom IconTheme (#157724 )

2024-10-29 10:51:38 +00:00

test

Fix TabBar tab icons not respecting custom IconTheme (#157724 )

2024-10-29 10:51:38 +00:00

test_fixes

Deprecate ThemeData.dialogBackgroundColor in favor of DialogThemeData.backgroundColor (#155072 )

2024-10-24 20:12:21 +00:00

test_private

Upgrade leak tracker. (#157369 )

2024-10-23 00:42:28 +00:00

test_profile

…

test_release

…

analysis_options.yaml

…

build.yaml

…

dart_test.yaml

…

LICENSE

…

pubspec.yaml

Upgrade leak tracker. (#157369 )

2024-10-23 00:42:28 +00:00

README.md

…

README.md

Flutter

Flutter is a new way to build high-performance, cross-platform mobile, web, and desktop apps. Flutter is optimized for today's — and tomorrow's — mobile and desktop devices. We are focused on low-latency input and high frame rates on all platforms.

See the getting started guide for information about using Flutter.