mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
3e26389e5d
Delete selection paint invalidation code. There is a slight change in behavior in FrameSelection::revealSelection. If you have a non-collapsed selection, then we'll center the start of the selection instead of the whole selection in some cases. There's a ton of callers of this code, so it's hard to be sure if any of this actually changes behavior for sky. In manual testing, I couldn't find any scenarios where there was a difference. Almost universally, when we call revealSelection, we have a CaretSelection. The only case I could think of where we have a RangeSelection is when modifying an off-screen selection (e.g. shift+right), but in that case we pass the RevealExtent option, so this patch doesn't change behavior there. Removing that caller makes all the rest of this rect computing code into dead code. R=abarth@chromium.org Review URL: https://codereview.chromium.org/823123003