mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00

History

Make sure _handleAppFrame is only registered once per frame (#30346 )

There were 2 possible scenarios in which _handleAppFrame is added more than once as a frame callback. When this happens it is possible that the second invocation will try to access _nextFrame.image when _nextFrame is null and crash. The 2 scenarios are:

Scenario 1

A GIF frame is decoded and a Flutter frame is executed before it's time to show the next GIF frame.
The timer that's waiting for enough time to elapse is invoked, and schedules a callback for the next Flutter frame(here).
Before the next Flutter frame is executed, MultiFrameImageStreamCompleter#removeListener is called followed by ``MultiFrameImageStreamCompleter#addListenerthat is invoking_decodeNextFrameAndSchedule` which is adding `_handleAppFrame` again as a next frame callback.
Scenario 2
removeListener and addListener are called multiple times in succession, every call to addListener can result in another registration of _handleAppFrame to the next Flutter frame callbacks list.

This patch fixes the issue by guarding against a second registration of _handleAppFrame.

2019-04-02 12:14:27 -07:00

lib

Make sure _handleAppFrame is only registered once per frame (#30346 )

2019-04-02 12:14:27 -07:00

test

Make sure _handleAppFrame is only registered once per frame (#30346 )

2019-04-02 12:14:27 -07:00

BUILD.gn

…

pubspec.yaml

Intercept errors thrown by synchronous Completers in image resolution. (#30139 )

2019-03-29 10:05:18 -07:00

README.md

…

README.md

Flutter

Flutter is a new way to build high-performance, cross-platform mobile apps. Flutter is optimized for today's — and tomorrow's — mobile devices. We are focused on low-latency input and high frame rates on Android and iOS.

See the getting started guide for information about using Flutter.