mirror of
https://github.com/flutter/flutter.git
synced 2026-01-18 19:54:36 +08:00
WIP Commits separated as follows: - Update lints in analysis_options files - Run `dart fix --apply` - Clean up leftover analysis issues - Run `dart format .` in the right places. Local analysis and testing passes. Checking CI now. Part of https://github.com/flutter/flutter/issues/178827 - Adoption of flutter_lints in examples/api coming in a separate change (cc @loic-sharma) ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
178 lines
4.6 KiB
Dart
178 lines
4.6 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Auto-format is disabled for this file to keep stack trace lines and columns stable.
|
|
|
|
// dart format off
|
|
|
|
import 'dart:js_interop';
|
|
|
|
import 'package:collection/collection.dart';
|
|
import 'package:flutter/foundation.dart';
|
|
import 'package:meta/dart2js.dart';
|
|
import 'package:web/web.dart' as web;
|
|
|
|
/// Expected sequence of method calls.
|
|
const List<String> callChain = <String>['baz', 'bar', 'foo'];
|
|
|
|
final List<StackFrame> expectedProfileStackFrames = callChain.map<StackFrame>((String method) {
|
|
return StackFrame(
|
|
number: -1,
|
|
packageScheme: '<unknown>',
|
|
package: '<unknown>',
|
|
packagePath: '<unknown>',
|
|
line: -1,
|
|
column: -1,
|
|
className: 'Object',
|
|
method: method,
|
|
source: '',
|
|
);
|
|
}).toList();
|
|
|
|
const List<StackFrame> expectedDebugStackFrames = <StackFrame>[
|
|
StackFrame(
|
|
number: -1,
|
|
packageScheme: 'package',
|
|
package: 'web_integration',
|
|
packagePath: 'stack_trace.dart',
|
|
line: 121,
|
|
column: 3,
|
|
className: '<unknown>',
|
|
method: 'baz',
|
|
source: '',
|
|
),
|
|
StackFrame(
|
|
number: -1,
|
|
packageScheme: 'package',
|
|
package: 'web_integration',
|
|
packagePath: 'stack_trace.dart',
|
|
line: 116,
|
|
column: 3,
|
|
className: '<unknown>',
|
|
method: 'bar',
|
|
source: '',
|
|
),
|
|
StackFrame(
|
|
number: -1,
|
|
packageScheme: 'package',
|
|
package: 'web_integration',
|
|
packagePath: 'stack_trace.dart',
|
|
line: 111,
|
|
column: 3,
|
|
className: '<unknown>',
|
|
method: 'foo',
|
|
source: '',
|
|
),
|
|
];
|
|
|
|
/// Tests that we do not crash while parsing Web stack traces.
|
|
///
|
|
/// This test is run in debug, profile, and release modes.
|
|
void main() async {
|
|
final output = StringBuffer();
|
|
try {
|
|
try {
|
|
foo();
|
|
} catch (expectedError, expectedStackTrace) {
|
|
final List<StackFrame> parsedFrames = StackFrame.fromStackTrace(expectedStackTrace);
|
|
if (parsedFrames.isEmpty) {
|
|
throw Exception(
|
|
'Failed to parse stack trace. Got empty list of stack frames.\n'
|
|
'Stack trace:\n$expectedStackTrace',
|
|
);
|
|
}
|
|
|
|
// Symbols in release mode are randomly obfuscated, so there's no good way to
|
|
// validate the contents. However, profile mode can be checked.
|
|
if (kProfileMode) {
|
|
_checkStackFrameContents(parsedFrames, expectedProfileStackFrames, expectedStackTrace);
|
|
}
|
|
|
|
if (kDebugMode) {
|
|
_checkStackFrameContents(parsedFrames, expectedDebugStackFrames, expectedStackTrace);
|
|
}
|
|
}
|
|
output.writeln('--- TEST SUCCEEDED ---');
|
|
} catch (unexpectedError, unexpectedStackTrace) {
|
|
output.writeln('--- UNEXPECTED EXCEPTION ---');
|
|
output.writeln(unexpectedError);
|
|
output.writeln(unexpectedStackTrace);
|
|
output.writeln('--- TEST FAILED ---');
|
|
}
|
|
await web.window
|
|
.fetch('/test-result'.toJS, web.RequestInit(method: 'POST', body: '$output'.toJS))
|
|
.toDart;
|
|
print(output);
|
|
}
|
|
|
|
@noInline
|
|
void foo() {
|
|
bar();
|
|
}
|
|
|
|
@noInline
|
|
void bar() {
|
|
baz();
|
|
}
|
|
|
|
@noInline
|
|
void baz() {
|
|
throw Exception('Test error message');
|
|
}
|
|
|
|
void _checkStackFrameContents(
|
|
List<StackFrame> parsedFrames,
|
|
List<StackFrame> expectedFrames,
|
|
dynamic stackTrace,
|
|
) {
|
|
// Filter out stack frames outside this library so this test is less brittle.
|
|
final List<StackFrame> actual = parsedFrames
|
|
.where((StackFrame frame) => callChain.contains(frame.method))
|
|
.toList();
|
|
final bool stackFramesAsExpected = ListEquality<StackFrame>(
|
|
StackFrameEquality(),
|
|
).equals(actual, expectedFrames);
|
|
if (!stackFramesAsExpected) {
|
|
throw Exception(
|
|
'Stack frames parsed incorrectly:\n'
|
|
'Expected:\n${expectedFrames.join('\n')}\n'
|
|
'Actual:\n${actual.join('\n')}\n'
|
|
'Stack trace:\n$stackTrace',
|
|
);
|
|
}
|
|
}
|
|
|
|
/// Use custom equality to ignore [StackFrame.source], which is not important
|
|
/// for the purposes of this test.
|
|
class StackFrameEquality implements Equality<StackFrame> {
|
|
@override
|
|
bool equals(StackFrame e1, StackFrame e2) {
|
|
return e1.number == e2.number &&
|
|
e1.packageScheme == e2.packageScheme &&
|
|
e1.package == e2.package &&
|
|
e1.packagePath == e2.packagePath &&
|
|
e1.line == e2.line &&
|
|
e1.column == e2.column &&
|
|
e1.className == e2.className &&
|
|
e1.method == e2.method;
|
|
}
|
|
|
|
@override
|
|
int hash(StackFrame e) {
|
|
return Object.hash(
|
|
e.number,
|
|
e.packageScheme,
|
|
e.package,
|
|
e.packagePath,
|
|
e.line,
|
|
e.column,
|
|
e.className,
|
|
e.method,
|
|
);
|
|
}
|
|
|
|
@override
|
|
bool isValidKey(Object? o) => o is StackFrame;
|
|
}
|