mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
35cb38e820
The need for the FlutterApplication NSApplication subclass was eliminated in eef10ab310178c3e646b255d7f3073984d2359f7. The relevant app termination logic was moved into FlutterAppDelegate in that patch. Removing FlutterApplication needs to be done in three stages: 1. Migrate logic to FlutterAppDelegate (done in above patch) 2. Update Flutter tool template. Update migrator to migrate all apps using FlutterApplication back to NSApplication. This is done in https://github.com/flutter/flutter/pull/124173. 3. Eliminate FlutterApplication.h header since all references to it have now been removed. No tests since, as described above, this is the removal of unused (as of step 2 above) code. Issue: https://github.com/flutter/flutter/issues/30735 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [X] I listed at least one issue that this PR fixes in the description above. - [ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I signed the [CLA]. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat