Brandon DeRosier 30fe68f402 [Impeller] Don't cull readbacks outside the damage rect. (flutter/engine#46705) ...

Resolves https://github.com/flutter/flutter/issues/136058.

The damage rect properly expands to include the backdrop filter readback area to a certain extent, but it suddenly gets excluded once it no longer partially overlaps with the damage rect. This caused the illusion of EntityPass improperly culling the backdrop entity, leading me into a bit of a wild goose chase.

Before:

https://github.com/flutter/engine/assets/919017/94b8c077-0945-4a2c-96e0-27230d980c38

After:

https://github.com/flutter/engine/assets/919017/f1c78365-6e9b-46cb-9e69-33472d488831

2023-10-10 20:55:05 +00:00

engine/src/flutter

[Impeller] Don't cull readbacks outside the damage rect. (flutter/engine#46705)

2023-10-10 20:55:05 +00:00

DEPS

Roll Skia from 475286f0f6f1 to 06145491fd17 (1 revision) (flutter/engine#46728)

2023-10-10 19:31:20 +00:00

Description

Flutter makes it easy and fast to build beautiful apps for mobile and beyond

androidapp-frameworkcross-platformdartdart-platformdesktopflutterflutter-packagefuchsiaioslinux-desktopmacosmaterial-designmobilemobile-developmentskiawebweb-frameworkwindows

2.5 GiB

Languages

Dart 75%

C++ 16.5%

Objective-C++ 2.9%

Java 2.8%

Objective-C 0.7%

Other 1.9%