585e20a15f
**(edited 4 december) PR EDITED TO FIT LATEST COMMENTS** Developper may want to remove a route in the background while an other one is displayed. To do so, developer can use removeRoute(). RemoveRoute() didn't resolve futures created by Navigator.push and so code which await for Navigator.push will never end. By calling complete() inside removeRoute, futures are well resolved. In addition that also allow to pass some result through removeRoute. Ex: ```dart Navigator.of(context).removeRoute(route, "test"); Navigator.of(context).removeRoute(route, object); ``` This PR aim to fix this issue : https://github.com/flutter/flutter/issues/157505 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Directory contents
The .yaml files in these directories are used to
define the dart fix framework refactorings
used by the Flutter framework.
The number of fix rules defined in a file should not exceed 50 for better
maintainability. Searching for title: in a given .yaml file will account
for the number of fixes. Splitting out fix rules should be done by class.
When adding a new .yaml file, make a copy of fix_template.yaml. If the new
file is not for generic library fixes (fix_material.yaml), ensure it is
enclosed in an appropriate library directory (fix_data/fix_material), and
named after the class. Fix files outside of generic libraries should represent
individual classes (fix_data/fix_material/fix_app_bar.yaml).
See the flutter/packages/flutter/test_fixes directory for the tests that validate these fix rules.
To run these tests locally, execute this command in the flutter/packages/flutter/test_fixes directory.
dart fix --compare-to-golden
For more documentation about Data Driven Fixes, see https://dart.dev/go/data-driven-fixes#test-folder.
To learn more about how fixes are authored in package:flutter, see Data driven Fixes.
When making structural changes to this directory
The tests in this directory are also invoked from external repositories. Specifically, the CI system for the dart-lang/sdk repo runs these tests in order to ensure that changes to the dart fix file format do not break Flutter.
See tools/bots/flutter/analyze_flutter_flutter.sh for where the tests are invoked.
When possible, please coordinate changes to this directory that might affect the
analyze_flutter_flutter.sh script.