mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
20c7e3bda5
Fixes #173721 The `CupertinoNavigationBar` was not considering large title height extension. I added 4 tests to ensure correct heights for possible variants : - _CupertinoNavigationBar has correct height_ - _CupertinoNavigationBar with bottom widget has correct height_ - _CupertinoNavigationBar.large has correct height_ - _CupertinoNavigationBar.large with bottom widget has correct height_ | Master branch | PR | |--------|--------| | <img width="645" height="1398" alt="Simulator Screenshot - iPhone 16 Plus - 2025-07-07 at 11 18 50" src="https://github.com/user-attachments/assets/abcd3c3b-bb38-410b-abf4-48372af9029e" /> | <img width="645" height="1398" alt="Simulator Screenshot - iPhone 16 Plus - 2025-07-07 at 11 19 00" src="https://github.com/user-attachments/assets/1d7e1fc4-74f2-431f-9f8e-7fdff03df6fe" /> | ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md