flutter_flutter/engine/core/css/RuleFeature.cpp
Elliott Sprehn f4546b7716 Store features in the ScopedStyleResoolver.
This now means that using a class/id/attribute selector in one scope will
not cause style recalcs in other scopes in the page when something with
that feature changes.

It also removes an iteration over all the scopes that used to collect
features.

I also removed all the extra cases around adding/removing classes since
the general case can handle them.

In addition I removed the check for classStringHasClassName which looked
to see if the string was all whitespace. This check dated way back to
fixing an assert in code we don't even have anymore. Assertion fix aside
all the extra check optimized for was if you wrote class="  " with no
names, which will now cause an extra malloc of the SpaceSplitString::Data.
This seems super rare, it makes more sense to not scan the class string
every time the list of classes changes which is far more common than
setting a string of only whitespace.

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/837883002
2015-01-06 22:22:44 -08:00

95 lines
3.4 KiB
C++

/*
* Copyright (C) 1999 Lars Knoll (knoll@kde.org)
* (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
* Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
* Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
* Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
* Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
* Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
* Copyright (c) 2011, Code Aurora Forum. All rights reserved.
* Copyright (C) Research In Motion Limited 2011. All rights reserved.
* Copyright (C) 2012 Google Inc. All rights reserved.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Library General Public
* License as published by the Free Software Foundation; either
* version 2 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Library General Public License for more details.
*
* You should have received a copy of the GNU Library General Public License
* along with this library; see the file COPYING.LIB. If not, write to
* the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
* Boston, MA 02110-1301, USA.
*/
#include "sky/engine/config.h"
#include "sky/engine/core/css/RuleFeature.h"
#include "sky/engine/core/css/CSSSelector.h"
#include "sky/engine/core/css/CSSSelectorList.h"
#include "sky/engine/core/css/RuleSet.h"
#include "sky/engine/core/css/StyleRule.h"
#include "sky/engine/core/dom/Element.h"
#include "sky/engine/core/dom/Node.h"
#include "sky/engine/wtf/BitVector.h"
namespace blink {
RuleFeatureSet::RuleFeatureSet()
{
}
RuleFeatureSet::~RuleFeatureSet()
{
}
void RuleFeatureSet::addSelectorFeatures(const CSSSelector& selector)
{
if (selector.match() == CSSSelector::Class)
m_classNames.add(selector.value());
else if (selector.match() == CSSSelector::Id)
m_idNames.add(selector.value());
else if (selector.isAttributeSelector())
m_attributeNames.add(selector.attribute().localName());
}
void RuleFeatureSet::collectFeaturesFromSelector(const CSSSelector& selector)
{
for (const CSSSelector* current = &selector; current; current = current->tagHistory()) {
addSelectorFeatures(*current);
collectFeaturesFromSelectorList(current->selectorList());
}
}
void RuleFeatureSet::collectFeaturesFromSelectorList(const CSSSelectorList* selectorList)
{
if (!selectorList)
return;
for (const CSSSelector* selector = selectorList->first(); selector; selector = CSSSelectorList::next(*selector))
collectFeaturesFromSelector(*selector);
}
void RuleFeatureSet::add(const RuleFeatureSet& other)
{
for (HashSet<AtomicString>::const_iterator it = other.m_classNames.begin(); it != other.m_classNames.end(); ++it)
m_classNames.add(*it);
for (HashSet<AtomicString>::const_iterator it = other.m_attributeNames.begin(); it != other.m_attributeNames.end(); ++it)
m_attributeNames.add(*it);
for (HashSet<AtomicString>::const_iterator it = other.m_idNames.begin(); it != other.m_idNames.end(); ++it)
m_idNames.add(*it);
}
void RuleFeatureSet::clear()
{
m_classNames.clear();
m_attributeNames.clear();
m_idNames.clear();
}
} // namespace blink