mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
74290d5007
Change hit testing to walk over the render tree instead of the RenderLayer tree. This is a step in the direction of removing the RenderLayer tree entirely. For now, there's a few calls back into RenderLayer that will be removed in a followup patch. This patch also breaks hit testing on transformed inlines. I'll be removing the ability to transform inlines in a followup patch anyways, so it's ok for hit testing to give the wrong result temporarily here. Almost all of this patch is just moving code from RenderLayer to RenderBox. The primary substantive change is in RenderBox::hitTestLayer. Instead of having hitTestChildren calls, we call collectSelfPaintingLayers, reverse sort by z-index (so we start at the top), and then iterate over the result. The test-case also exposes that we don't correctly hit transformed elements inside inline-blocks. I went back as far as 4153b8a515d54275934d4244aaf2d5a7a8fe3333 and the bug still happened. R=abarth@chromium.org Review URL: https://codereview.chromium.org/945693002
78 lines
2.6 KiB
C++
78 lines
2.6 KiB
C++
/*
|
|
* Copyright (C) 1999 Lars Knoll (knoll@kde.org)
|
|
* (C) 1999 Antti Koivisto (koivisto@kde.org)
|
|
* Copyright (C) 2003, 2006, 2007, 2009 Apple Inc. All rights reserved.
|
|
* Copyright (C) 2010, 2012 Google Inc. All rights reserved.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Library General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Library General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Library General Public License
|
|
* along with this library; see the file COPYING.LIB. If not, write to
|
|
* the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
|
|
* Boston, MA 02110-1301, USA.
|
|
*/
|
|
|
|
#ifndef SKY_ENGINE_CORE_RENDERING_RENDERLAYERMODELOBJECT_H_
|
|
#define SKY_ENGINE_CORE_RENDERING_RENDERLAYERMODELOBJECT_H_
|
|
|
|
#include "sky/engine/core/rendering/RenderObject.h"
|
|
|
|
namespace blink {
|
|
|
|
class RenderLayer;
|
|
|
|
enum LayerType {
|
|
NoLayer,
|
|
NormalLayer,
|
|
// An overflow clip layer is required for bookkeeping purposes,
|
|
// but does not force a layer to be self painting.
|
|
OverflowClipLayer,
|
|
};
|
|
|
|
class RenderLayerModelObject : public RenderObject {
|
|
public:
|
|
explicit RenderLayerModelObject(ContainerNode*);
|
|
virtual ~RenderLayerModelObject();
|
|
|
|
// This is the only way layers should ever be destroyed.
|
|
void destroyLayer();
|
|
|
|
void collectSelfPaintingLayers(Vector<RenderBox*>& layers);
|
|
bool hasSelfPaintingLayer() const;
|
|
RenderLayer* layer() const { return m_layer.get(); }
|
|
|
|
virtual void styleWillChange(StyleDifference, const RenderStyle& newStyle) override;
|
|
virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) override;
|
|
virtual void updateFromStyle() { }
|
|
|
|
virtual LayerType layerTypeRequired() const = 0;
|
|
|
|
// This is null for anonymous renderers.
|
|
ContainerNode* node() const { return toContainerNode(RenderObject::node()); }
|
|
protected:
|
|
void createLayer(LayerType);
|
|
|
|
virtual void willBeDestroyed() override;
|
|
private:
|
|
virtual bool isLayerModelObject() const override final { return true; }
|
|
|
|
OwnPtr<RenderLayer> m_layer;
|
|
|
|
// Used to store state between styleWillChange and styleDidChange
|
|
static bool s_wasFloating;
|
|
};
|
|
|
|
DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderLayerModelObject, isLayerModelObject());
|
|
|
|
} // namespace blink
|
|
|
|
#endif // SKY_ENGINE_CORE_RENDERING_RENDERLAYERMODELOBJECT_H_
|