Chinmay Garde c8ecb03fa8 Account for root surface transformation on the surfaces managed by the external view embedder. (flutter/engine#11384)
The earlier design speculated that embedders could affect the same
transformations on the layers post engine compositor presentation but before
final composition.

However, the linked issue points out that this design is not suitable for use
with hardware overlay planes. When rendering to the same, to affect the
transformation before composition, embedders would have to render to an
off-screen render target and then apply the transformation before presentation.
This patch negates the need for that off-screen render pass.

To be clear, the previous architecture is still fully viable. Embedders still
have full control over layer transformations before composition. This is an
optimization for the hardware overlay planes use-case.

Fixes b/139758641
2019-09-17 15:16:59 -07:00

68 lines
1.6 KiB
C++

// Copyright 2013 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifndef FLUTTER_TESTING_TEST_GL_SURFACE_H_
#define FLUTTER_TESTING_TEST_GL_SURFACE_H_
#include <cstdint>
#include "flutter/fml/macros.h"
#include "third_party/skia/include/gpu/GrContext.h"
namespace flutter {
namespace testing {
class TestGLSurface {
public:
TestGLSurface(SkISize surface_size);
~TestGLSurface();
const SkISize& GetSurfaceSize() const;
bool MakeCurrent();
bool ClearCurrent();
bool Present();
uint32_t GetFramebuffer() const;
bool MakeResourceCurrent();
void* GetProcAddress(const char* name) const;
sk_sp<SkSurface> GetOnscreenSurface();
sk_sp<GrContext> GetGrContext();
sk_sp<GrContext> CreateGrContext();
sk_sp<SkImage> GetRasterSurfaceSnapshot();
private:
// Importing the EGL.h pulls in platform headers which are problematic
// (especially X11 which #defineds types like Bool). Any TUs importing
// this header then become susceptible to failures because of platform
// specific craziness. Don't expose EGL internals via this header.
using EGLDisplay = void*;
using EGLContext = void*;
using EGLSurface = void*;
const SkISize surface_size_;
EGLDisplay display_;
EGLContext onscreen_context_;
EGLContext offscreen_context_;
EGLSurface onscreen_surface_;
EGLSurface offscreen_surface_;
sk_sp<GrContext> context_;
FML_DISALLOW_COPY_AND_ASSIGN(TestGLSurface);
};
} // namespace testing
} // namespace flutter
#endif // FLUTTER_TESTING_TEST_GL_SURFACE_H_