mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
10c52df4fb
issue: https://github.com/flutter/flutter/issues/142753 After https://github.com/flutter/engine/pull/50262 there were still some sigmas that could show shimmering around the sigma [50, 100] range which had a downsample amount of 1/16. This makes those ranges hang on to 1/8 for as long as possible. I'm unable to see any shimmering with `AiksTest.GaussianBlurAnimatedBackdrop` after this PR. I've also expanded that test so the clip region could be scaled to make sure that there aren't sizes which cause it to reappear. Testing: Expanded on manual testing. Since the error only manifests when evaluating multiple frames of rendering we don't have infrastructure to test that. Here is the graph of `GaussianBlurFilterContents::CalculateScale` after this change: <img width="903" alt="Screenshot 2024-02-05 at 2 10 41 PM" src="https://github.com/flutter/engine/assets/30870216/ac3b735a-95f0-4d7b-af12-58e1ae75278e"> ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat