auto-submit[bot] 0946357650 Reverts "Fail pre-submit if a negative image is encountered as part of goldctl imgtest add. (#51685)" (flutter/engine#51718) ...

Reverts: flutter/engine#51685
Initiated by: matanlurey
Reason for reverting: goldctl does not disambiguate negatives from untriaged images (see 9b9adad080/gold-client/cmd/goldctl/cmd_imgtest_test.go (L325)).
Original PR Author: matanlurey

Reviewed By: {mdebbar, gaaclarke}

This change reverts the following previous change:
`flutter/engine`-side fix for https://github.com/flutter/flutter/issues/145043.

- Before this PR, if a negative image was encountered, we'd silently pass pre-submit, merge, and turn the tree red.
- After this PR, a negative image both makes pre and post-submit red.

Added tests, and fixed up some unrelated tests that were accidentally setting `pid` instead of `exitCode`. Oops!

/cc @zanderso and @eyebrowsoffire (current engine sheriff).

2024-03-27 18:58:47 +00:00

..

src/flutter

Reverts "Fail pre-submit if a negative image is encountered as part of goldctl imgtest add. (#51685)" (flutter/engine#51718)

2024-03-27 18:58:47 +00:00