mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
32b513bbb2
…troyed. (flutter/engine#37539)" This reverts commit 7296b2b66dac82f04ebe9017320bde81a7b5f486. In b/422322882, we have done a small experiment on addtoapp Android, with and without a patched engine where `Dart_NotifyDestroyed` is not called: 1. Add a Flutter view 2. Measure memory with `adb shell dumpsys meminfo` 3. Call detach 5. Measure memory again "Call detach" refers to the following pseudocode: ```kt flutterViewContainer.removeView(flutterView) engine.activityControlSurface.detachFromActivity() engine.lifecycleChannel.appIsDetached() flutterView!!.detachFromFlutterEngine() ``` We observed that the memory recordings with and without the patched engine are mostly the same. @a-siva also mentioned that 7296b2b66dac82f04ebe9017320bde81a7b5f486 could be no longer needed today. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md