mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
0af96f055d
In Sky we can style share if our TreeScopes have the same styles, our :host styles are the same, and we'd inherit the same styles. This allows a lot of simplification to the style sharing logic since we don't need to deal with descendant selectors or tree boundary crossing rules: - We can remove the logic that was checking that we were distributed to the same insertion points since there's no ::content selectors. - We can check the actual inherited values instead of looking at the parentOrSHadowHostNode(). We used to look at the node in Blink because we were checking that you'd get the same descendant selectors applied. In Sky we instead want to make sure you'd inherit the same values. This also means we don't need the element().parentOrShadowHostElement() != parent case in the SharedStyleFinder which was trying to deal with descendant selectors again. I also removed the checks that were redundant with the checks inside supportsStyleSharing() which we always check before adding sharing candidates. Finally by refactoring the code to make the TreeScope style check work it exposed that the Document::styleSheets() and TreeScope::styleSheets() APIs are now dead. A future patch will delete the now dead StyleSheetList class as well. This change makes the city-list application share between all the items in the list, and all of the headers of the same type now share as well. R=ojan@chromium.org Review URL: https://codereview.chromium.org/796713002
81 lines
2.8 KiB
C++
81 lines
2.8 KiB
C++
/*
|
|
* Copyright (C) 2013 Google, Inc.
|
|
* Copyright (C) 1999 Lars Knoll (knoll@kde.org)
|
|
* Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Library General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Library General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Library General Public License
|
|
* along with this library; see the file COPYING.LIB. If not, write to
|
|
* the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
|
|
* Boston, MA 02110-1301, USA.
|
|
*/
|
|
|
|
#ifndef SKY_ENGINE_CORE_CSS_RESOLVER_SHAREDSTYLEFINDER_H_
|
|
#define SKY_ENGINE_CORE_CSS_RESOLVER_SHAREDSTYLEFINDER_H_
|
|
|
|
#include "sky/engine/core/css/resolver/ElementResolveContext.h"
|
|
#include "sky/engine/core/dom/Element.h"
|
|
|
|
namespace blink {
|
|
|
|
class Element;
|
|
class Node;
|
|
class RenderStyle;
|
|
class RuleFeatureSet;
|
|
class RuleSet;
|
|
class SpaceSplitString;
|
|
class StyleResolver;
|
|
|
|
class SharedStyleFinder {
|
|
STACK_ALLOCATED();
|
|
public:
|
|
// RuleSets are passed non-const as the act of matching against them can cause them
|
|
// to be compacted. :(
|
|
SharedStyleFinder(const ElementResolveContext& context,
|
|
const RuleFeatureSet& features, StyleResolver& styleResolver)
|
|
: m_elementAffectedByClassRules(false)
|
|
, m_features(features)
|
|
, m_styleResolver(styleResolver)
|
|
, m_context(context)
|
|
, m_renderingParent(nullptr)
|
|
{ }
|
|
|
|
RenderStyle* findSharedStyle();
|
|
|
|
private:
|
|
Element* findElementForStyleSharing() const;
|
|
|
|
// Only used when we're collecting stats on styles.
|
|
bool documentContainsValidCandidate() const;
|
|
|
|
bool classNamesAffectedByRules(const Element&) const;
|
|
bool attributesAffectedByRules(const Element&) const;
|
|
|
|
bool canShareStyleWithElement(Element& candidate) const;
|
|
bool sharingCandidateHasIdenticalStyleAffectingAttributes(Element& candidate) const;
|
|
bool sharingCandidateCanShareHostStyles(Element& candidate) const;
|
|
bool sharingCandidateDistributedToSameInsertionPoint(Element& candidate) const;
|
|
|
|
Element& element() const { return *m_context.element(); }
|
|
Document& document() const { return element().document(); }
|
|
|
|
bool m_elementAffectedByClassRules;
|
|
const RuleFeatureSet& m_features;
|
|
StyleResolver& m_styleResolver;
|
|
const ElementResolveContext& m_context;
|
|
ContainerNode* m_renderingParent;
|
|
};
|
|
|
|
} // namespace blink
|
|
|
|
#endif // SKY_ENGINE_CORE_CSS_RESOLVER_SHAREDSTYLEFINDER_H_
|