mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
WIP Commits separated as follows: - Update lints in analysis_options files - Run `dart fix --apply` - Clean up leftover analysis issues - Run `dart format .` in the right places. Local analysis and testing passes. Checking CI now. Part of https://github.com/flutter/flutter/issues/178827 - Adoption of flutter_lints in examples/api coming in a separate change (cc @loic-sharma) ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
169 lines
5.3 KiB
Dart
169 lines
5.3 KiB
Dart
// Copyright 2014 The Flutter Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
import 'package:flutter/widgets.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
void main() {
|
|
// Regression test for https://github.com/flutter/flutter/issues/96024
|
|
testWidgets('CustomScrollView.center update test 1', (WidgetTester tester) async {
|
|
final Key centerKey = UniqueKey();
|
|
late StateSetter setState;
|
|
var hasKey = false;
|
|
await tester.pumpWidget(
|
|
Directionality(
|
|
textDirection: TextDirection.ltr,
|
|
child: CustomScrollView(
|
|
center: centerKey,
|
|
slivers: <Widget>[
|
|
const SliverToBoxAdapter(key: Key('a'), child: SizedBox(height: 100.0)),
|
|
StatefulBuilder(
|
|
key: centerKey,
|
|
builder: (BuildContext context, StateSetter setter) {
|
|
setState = setter;
|
|
if (hasKey) {
|
|
return const SliverToBoxAdapter(key: Key('b'), child: SizedBox(height: 100.0));
|
|
} else {
|
|
return const SliverToBoxAdapter(child: SizedBox(height: 100.0));
|
|
}
|
|
},
|
|
),
|
|
],
|
|
),
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
|
|
// Change the center key will trigger the old RenderObject remove and a new
|
|
// RenderObject insert.
|
|
setState(() {
|
|
hasKey = true;
|
|
});
|
|
|
|
await tester.pumpAndSettle();
|
|
|
|
// Pass without throw.
|
|
});
|
|
|
|
testWidgets('CustomScrollView.center update test 2', (WidgetTester tester) async {
|
|
const slivers1 = <Widget>[
|
|
SliverToBoxAdapter(key: Key('a'), child: SizedBox(height: 100.0)),
|
|
SliverToBoxAdapter(key: Key('b'), child: SizedBox(height: 100.0)),
|
|
SliverToBoxAdapter(key: Key('c'), child: SizedBox(height: 100.0)),
|
|
];
|
|
|
|
const slivers2 = <Widget>[
|
|
SliverToBoxAdapter(key: Key('c'), child: SizedBox(height: 100.0)),
|
|
SliverToBoxAdapter(key: Key('d'), child: SizedBox(height: 100.0)),
|
|
SliverToBoxAdapter(key: Key('a'), child: SizedBox(height: 100.0)),
|
|
];
|
|
|
|
Widget buildFrame(List<Widget> slivers, Key center) {
|
|
return Directionality(
|
|
textDirection: TextDirection.ltr,
|
|
child: CustomScrollView(center: center, slivers: slivers),
|
|
);
|
|
}
|
|
|
|
await tester.pumpWidget(buildFrame(slivers1, const Key('b')));
|
|
await tester.pumpAndSettle();
|
|
|
|
await tester.pumpWidget(buildFrame(slivers2, const Key('d')));
|
|
await tester.pumpAndSettle();
|
|
|
|
// Pass without throw.
|
|
});
|
|
|
|
testWidgets('CustomScrollView.center', (WidgetTester tester) async {
|
|
await tester.pumpWidget(
|
|
const Directionality(
|
|
textDirection: TextDirection.ltr,
|
|
child: CustomScrollView(
|
|
slivers: <Widget>[
|
|
SliverToBoxAdapter(key: Key('a'), child: SizedBox(height: 100.0)),
|
|
SliverToBoxAdapter(key: Key('b'), child: SizedBox(height: 100.0)),
|
|
],
|
|
center: Key('a'),
|
|
),
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
expect(
|
|
tester.getRect(
|
|
find.descendant(of: find.byKey(const Key('a')), matching: find.byType(SizedBox)),
|
|
),
|
|
const Rect.fromLTRB(0.0, 0.0, 800.0, 100.0),
|
|
);
|
|
expect(
|
|
tester.getRect(
|
|
find.descendant(of: find.byKey(const Key('b')), matching: find.byType(SizedBox)),
|
|
),
|
|
const Rect.fromLTRB(0.0, 100.0, 800.0, 200.0),
|
|
);
|
|
});
|
|
|
|
testWidgets('CustomScrollView.center', (WidgetTester tester) async {
|
|
await tester.pumpWidget(
|
|
const Directionality(
|
|
textDirection: TextDirection.ltr,
|
|
child: CustomScrollView(
|
|
slivers: <Widget>[
|
|
SliverToBoxAdapter(key: Key('a'), child: SizedBox(height: 100.0)),
|
|
SliverToBoxAdapter(key: Key('b'), child: SizedBox(height: 100.0)),
|
|
],
|
|
center: Key('b'),
|
|
),
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
expect(
|
|
tester.getRect(
|
|
find.descendant(
|
|
of: find.byKey(const Key('a'), skipOffstage: false),
|
|
matching: find.byType(SizedBox, skipOffstage: false),
|
|
),
|
|
),
|
|
const Rect.fromLTRB(0.0, -100.0, 800.0, 0.0),
|
|
);
|
|
expect(
|
|
tester.getRect(
|
|
find.descendant(of: find.byKey(const Key('b')), matching: find.byType(SizedBox)),
|
|
),
|
|
const Rect.fromLTRB(0.0, 0.0, 800.0, 100.0),
|
|
);
|
|
});
|
|
|
|
testWidgets('CustomScrollView.anchor', (WidgetTester tester) async {
|
|
await tester.pumpWidget(
|
|
const Directionality(
|
|
textDirection: TextDirection.ltr,
|
|
child: CustomScrollView(
|
|
slivers: <Widget>[
|
|
SliverToBoxAdapter(key: Key('a'), child: SizedBox(height: 100.0)),
|
|
SliverToBoxAdapter(key: Key('b'), child: SizedBox(height: 100.0)),
|
|
],
|
|
center: Key('b'),
|
|
anchor: 1.0,
|
|
),
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
expect(
|
|
tester.getRect(
|
|
find.descendant(of: find.byKey(const Key('a')), matching: find.byType(SizedBox)),
|
|
),
|
|
const Rect.fromLTRB(0.0, 500.0, 800.0, 600.0),
|
|
);
|
|
expect(
|
|
tester.getRect(
|
|
find.descendant(
|
|
of: find.byKey(const Key('b'), skipOffstage: false),
|
|
matching: find.byType(SizedBox, skipOffstage: false),
|
|
),
|
|
),
|
|
const Rect.fromLTRB(0.0, 600.0, 800.0, 700.0),
|
|
);
|
|
});
|
|
}
|